fix(engine): never use a dot notation of patched objects #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caridy
commented
Jun 13, 2018
| @@ -36,7 +36,9 @@ const eventShadowDescriptors: PropertyDescriptorMap = { | |||
| return currentTarget; | |||
| } | |||
| return patchShadowDomTraversalMethods(currentTarget); | |||
| } | |||
| }, | |||
| enumerable: true, | |||
There was a problem hiding this comment.
@ravijayaramappa this fixes the issue that you mentioned for target and current target.
caridy
commented
Jun 13, 2018
| @@ -182,7 +185,7 @@ function getWrappedRootListener(vm: VM, listener: EventListener): WrappedListene | |||
| // it is coming from an slotted element | |||
| isChildNode(getRootNode.call(target, event), currentTarget as Node) || | |||
| // it is not composed and its is coming from from shadow | |||
| (composed === false && getRootNode.call(event.target) === currentTarget)) { | |||
| (composed === false && getRootNode.call(target) === currentTarget)) { | |||
There was a problem hiding this comment.
we were using the event.target that was returning an already retargeted target.
caridy
commented
Jun 13, 2018
| @@ -318,7 +321,8 @@ function detachDOMListener(vm: VM, type: string, wrappedListener: WrappedListene | |||
|
|
|||
| const NON_COMPOSED = { composed: false }; | |||
| export function isValidEventForCustomElement(event: Event): boolean { | |||
| const { target, currentTarget } = event; | |||
| const target = eventTargetGetter.call(event); | |||
There was a problem hiding this comment.
never use the . notation at the low level, use the cached getter to avoid getting a patched value.
davidturissini
approved these changes
Jun 13, 2018
Benchmark resultsBase commit: lwc-engine-benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Does this PR introduce a breaking change?