Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): handling dispatching events inside of root event handlers #391

Merged
merged 2 commits into from
Jun 8, 2018

Conversation

davidturissini
Copy link
Contributor

Details

  • Handling event listeners dispatched withing root event listeners

Does this PR introduce a breaking change?

  • Yes
  • No

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 9cbd853 | Target commit: d158045

lwc-engine-benchmark

table-append-1k metric base(9cbd853) target(d158045) trend
benchmark-table/append/1k duration 143.00 (± 5.20 ms) 143.50 (± 4.90 ms) -0.35% 👌
table-clear-1k metric base(9cbd853) target(d158045) trend
benchmark-table/clear/1k duration 11.40 (± 0.40 ms) 11.15 (± 0.55 ms) 2.19% 👌
table-create-10k metric base(9cbd853) target(d158045) trend
benchmark-table/create/10k duration 845.10 (± 3.30 ms) 841.00 (± 3.70 ms) 0.49% 👍
table-create-1k metric base(9cbd853) target(d158045) trend
benchmark-table/create/1k duration 99.20 (± 2.60 ms) 100.00 (± 2.10 ms) -0.81% 👌
table-update-10th-1k metric base(9cbd853) target(d158045) trend
benchmark-table/update-10th/1k duration 90.10 (± 6.10 ms) 83.70 (± 4.00 ms) 7.10% 👍
tablecmp-append-1k metric base(9cbd853) target(d158045) trend
benchmark-table-component/append/1k duration 255.10 (± 5.80 ms) 253.70 (± 5.80 ms) 0.55% 👌
tablecmp-clear-1k metric base(9cbd853) target(d158045) trend
benchmark-table/clear/1k duration 35.30 (± 1.50 ms) 36.70 (± 1.50 ms) -3.97% 👎
tablecmp-create-10k metric base(9cbd853) target(d158045) trend
benchmark-table-component/create/10k duration 1701.50 (± 16.80 ms) 1728.30 (± 14.10 ms) -1.58% 👎
tablecmp-create-1k metric base(9cbd853) target(d158045) trend
benchmark-table-component/create/1k duration 200.50 (± 4.10 ms) 198.40 (± 3.50 ms) 1.05% 👌
tablecmp-update-10th-1k metric base(9cbd853) target(d158045) trend
benchmark-table-component/update-10th/1k duration 75.60 (± 4.30 ms) 75.20 (± 5.00 ms) 0.53% 👌

@diervo diervo merged commit 02b9402 into master Jun 8, 2018
@diervo diervo deleted the dturissini/double-root-dispatch-event-target-fix branch June 8, 2018 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants