Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): expose shadowRoot if the mode is open #367

Merged
merged 1 commit into from
Jun 2, 2018

Conversation

caridy
Copy link
Contributor

@caridy caridy commented Jun 2, 2018

Details

  • expose elm.shadowRoot if mode is open (default to open today)
  • rootElm.querySelector* remaps to rootElm.shadowRoot.querySelector*

Does this PR introduce a breaking change?

  • No

@caridy caridy requested review from davidturissini and diervo June 2, 2018 00:01
@diervo diervo merged commit 3de5ec3 into master Jun 2, 2018
@diervo diervo deleted the caridy/open-shadow-root branch June 2, 2018 01:04
@davidturissini davidturissini restored the caridy/open-shadow-root branch June 2, 2018 01:05
@pmdartus pmdartus deleted the caridy/open-shadow-root branch June 18, 2018 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants