fix(engine): live bindings for value and checked properties 3nd attempt #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
May 24, 2018
| assert.logError(`Invalid attempt to set property ${key} from ${vm} to ${newValue}. This property was decorated with @api, and can only be changed via the template.`); | ||
| } | ||
| vmBeingUpdated = null; // releasing the lock | ||
| // not need to wrap or check the value since that is happening somewhere else |
caridy
commented
May 24, 2018
| } | ||
| } else if (process.env.NODE_ENV !== 'production') { |
There was a problem hiding this comment.
this condition was moved up to only run when vmBeingUpdated is not the current vm, which means it is not a controlled mutation. In which case we warn.
Benchmark resultsBase commit: lwc-engine-benchmark
|
davidturissini
approved these changes
May 24, 2018
trevor-bliss
pushed a commit
that referenced
this pull request
May 25, 2018
pmdartus
deleted the
caridy/fix-live-bindings-value-and-checked-props-third-attempt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Follow up on #312.
As today, manual mutations in regular HTML element are allowed, while manual mutations on custom elements are not allowed, arguing that the element is controlled by the template, and mutations can only be carry on by it.
With this PR we are relaxing this, and only giving them a warning with more details. This facilitate authors to force pushing new values down to other elements that they own.
Does this PR introduce a breaking change?