fix: simplify style logic in template compiler #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmdartus
force-pushed
the
pmdartus/fix-invalid-style-parsing
branch
from
29300d9 to
33236d3
Compare
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
caridy
reviewed
May 18, 2018
| @@ -76,7 +76,7 @@ export interface VNodeData { | |||
| props?: Props; | |||
| attrs?: Attrs; | |||
| class?: Classes; | |||
| style?: VNodeStyle; | |||
| style?: VNodeStyle | string; | |||
There was a problem hiding this comment.
we should mark this as a difference since this file is copied and modified from snabbdom, so we know when copying the new one.
There was a problem hiding this comment.
additionally, we can expand this type in LWC only.
There was a problem hiding this comment.
We will fix this in an upcoming PR when removing the engine registry.
caridy
reviewed
May 18, 2018
| style[name] = cur; | ||
| } | ||
| if (cur !== (oldStyle as VNodeStyle)[name]) { | ||
| style.setProperty(name, cur); |
There was a problem hiding this comment.
this is code copied from snabbdom (mostly). I wonder why did they use style[name] = cur instead of setProperty. was it because of the camelCase?
There was a problem hiding this comment.
Yes the setProperty accepts the kebab-case version of it. While the direct set on the object accepts the camelCase.
I think they want to privilege the camelCase approach because of the developer ergonomic:
// camelCase
h('span', {
style: {
border: '1px solid #bada55',
fontWeight: 'bold'
}
}, 'Say my name, and every colour illuminates');
// kebab-case
h('span', {
style: {
border: '1px solid #bada55',
'font-weight': 'bold'
}
}, 'Say my name, and every colour illuminates');But because we don't allow objects for styles, we don't have to deal with the camelCase.
|
I still don't trust BEST results. Instead of improving, it is now slower on append operation, which is weird. /cc @diervo |
|
@caridy you only say you don’t trust best when you don’t agree with the results. I believe using setAtribute is quite expensive compared with assigned it directly so I can understand why the changes really don’t do much |
|
It appears that FF and IE11 are (15%) slower when using |
Benchmark resultsBase commit: lwc-engine-benchmark
|
|
@caridy Ready for a second pass of review. |
pmdartus
commented
May 29, 2018
| @@ -44,14 +41,8 @@ function updateStyle(oldVnode: VNode, vnode: VNode) { | |||
|
|
|||
| for (name in newStyle) { | |||
| const cur = newStyle[name]; | |||
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
|
This PR is now ready to be merged. Waiting for master to stabilize and the new compiler to get deployed before merging. |
caridy
approved these changes
May 30, 2018
|
let's roll @pmdartus |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
setPropertywhen patching style.Fix #227
Does this PR introduce a breaking change?