Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade compat packages #301

Merged
merged 1 commit into from
May 15, 2018
Merged

fix: upgrade compat packages #301

merged 1 commit into from
May 15, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented May 15, 2018

Details

Forward port refactor of intrinsics on es5-proxy-compat
https://github.com/salesforce/es5-proxy-compat/commit/f467ed2dd229e429d5203d6a84c83dabb19e6f66

Does this PR introduce a breaking change?

No

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 07213f0 | Target commit: 5e5c86a

lwc-engine-benchmark

table-append-1k metric base(07213f0) target(5e5c86a) trend
benchmark-table/append/1k duration 146.60 (± 3.90 ms) 149.20 (± 6.50 ms) -1.77% 👌
table-clear-1k metric base(07213f0) target(5e5c86a) trend
benchmark-table/clear/1k duration 11.60 (± 0.30 ms) 11.80 (± 0.50 ms) -1.72% 👎
table-create-10k metric base(07213f0) target(5e5c86a) trend
benchmark-table/create/10k duration 847.60 (± 4.70 ms) 841.50 (± 4.10 ms) 0.72% 👍
table-create-1k metric base(07213f0) target(5e5c86a) trend
benchmark-table/create/1k duration 101.90 (± 2.30 ms) 101.30 (± 1.90 ms) 0.59% 👌
table-update-10th-1k metric base(07213f0) target(5e5c86a) trend
benchmark-table/update-10th/1k duration 87.00 (± 6.40 ms) 90.60 (± 5.30 ms) -4.14% 👌
tablecmp-append-1k metric base(07213f0) target(5e5c86a) trend
benchmark-table-component/append/1k duration 245.30 (± 2.80 ms) 230.10 (± 17.90 ms) 6.20% 👍
tablecmp-clear-1k metric base(07213f0) target(5e5c86a) trend
benchmark-table/clear/1k duration 31.30 (± 1.40 ms) 31.50 (± 1.50 ms) -0.64% 👌
tablecmp-create-10k metric base(07213f0) target(5e5c86a) trend
benchmark-table-component/create/10k duration 1724.50 (± 8.10 ms) 1704.70 (± 7.00 ms) 1.15% 👍
tablecmp-create-1k metric base(07213f0) target(5e5c86a) trend
benchmark-table-component/create/1k duration 192.60 (± 3.00 ms) 195.40 (± 4.40 ms) -1.45% 👎
tablecmp-update-10th-1k metric base(07213f0) target(5e5c86a) trend
benchmark-table-component/update-10th/1k duration 75.20 (± 3.60 ms) 77.00 (± 3.90 ms) -2.39% 👌

@diervo diervo merged commit cf5f5ae into master May 15, 2018
@diervo diervo deleted the dval/upgradeMasterCompat branch May 15, 2018 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant