fix(husky): fix husky release #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsBase commit: lwc-engine-benchmark
|
ekashida
reviewed
May 11, 2018
| @@ -21,15 +21,21 @@ | |||
| "release:internalbeta": "yarn prepare && lerna publish --canary=beta --skip-git --yes --registry='https://nexus.soma.salesforce.com/nexus/content/repositories/npmjs-internal/'", | |||
| "changelog": "yarn changelog:generate && yarn changelog:publish", | |||
| "changelog:generate": "conventional-changelog -p angular -i CHANGELOG.md -s -r 0", | |||
| "changelog:publish": "git add CHANGELOG.md && git commit -m 'docs(changelog): publish release changelog' && git push", | |||
| "commitmsg": "validate-commit-msg" | |||
There was a problem hiding this comment.
How was this script getting triggered before?
There was a problem hiding this comment.
with an old husky interface, by specifying 'commitmsg' you tell husky to intercept commit message - automagic. With a new version of husky they explicitly make you create 'husky' object in your packages.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Use commitlint instead of validate-msg library. Fixes #171
Does this PR introduce a breaking change?