Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): do not use global removeEventListener #174

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

trevor-bliss
Copy link
Contributor

Details

Do not use global removeEventListener. Fixes IE11.

Does this PR introduce a breaking change?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:
Please check if your PR fulfills the following requirements:

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: f8623c8 | Target commit: d601c03

benchmark base(f8623c8) target(d601c03) trend
table-append-1k.benchmark:benchmark-table/append/1k 240.69 (± 3.28 ms) 271.68 (± 13.47 ms) 👎
table-clear-1k.benchmark:benchmark-table/clear/1k 12.46 (± 0.38 ms) 13.63 (± 0.68 ms) 👎
table-create-10k.benchmark:benchmark-table/create/10k 1411.16 (± 14.91 ms) 1580.32 (± 42.04 ms) 👎
table-create-1k.benchmark:benchmark-table/create/1k 149.81 (± 1.32 ms) 163.87 (± 4.24 ms) 👎
table-update-10th-1k.benchmark:benchmark-table/update-10th/1k 126.47 (± 1.26 ms) 136.34 (± 5.85 ms) 👎
tablecmp-append-1k.benchmark:benchmark-table-component/append/1k 329.05 (± 4.76 ms) 360.33 (± 10.24 ms) 👎
tablecmp-clear-1k.benchmark:benchmark-table/clear/1k 33.49 (± 0.86 ms) 35.80 (± 2.06 ms) 👎
tablecmp-create-10k.benchmark:benchmark-table-component/create/10k 2477.68 (± 25.37 ms) 2630.34 (± 45.61 ms) 👎
tablecmp-create-1k.benchmark:benchmark-table-component/create/1k 259.12 (± 2.60 ms) 299.46 (± 14.77 ms) 👎
tablecmp-update-10th-1k.benchmark:benchmark-table-component/update-10th/1k 116.28 (± 1.95 ms) 124.70 (± 2.85 ms) 👎

@trevor-bliss trevor-bliss merged commit ac38122 into master Mar 26, 2018
@trevor-bliss trevor-bliss deleted the tbliss/removeEventListener branch March 26, 2018 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants