fix(engine): infinite loop in getErrorBoundaryVM #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apapko
approved these changes
Feb 3, 2020
| }; | ||
|
|
||
| @api | ||
| toggleFlag(flag) { | ||
| this.state[flag] = true; | ||
| } | ||
|
|
There was a problem hiding this comment.
nice, reduced so much space!
|
Let's improve this test. We originally created a single root component because this test was originally written as a webdriver test. This is not needed anymore, we can create each component individually now in Karma. If someone is in a clean-up mood... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes the infinite loop that happens in
getErrorBoundaryVMwhen a deeply nested component errors out.Does this PR introduce breaking changes?
No, it does not introduce breaking changes.If yes, please describe the impact and migration path for existing applications.
The PR fulfills these requirements: