Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup-plugin-lwc-compiler): Removing any COMPAT code on DEV #158

Merged
merged 2 commits into from
Mar 15, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Mar 15, 2018

Details

Adding branch check to avoid sending polyfills in other modes.

Does this PR introduce a breaking change?

  • No

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: c89c20b | Target commit: c112ff4

benchmark base(c89c20b) target(c112ff4) trend
table-append-1k.benchmark:benchmark-table/append/1k 285.20 (± 9.13 ms) 268.57 (± 7.60 ms) 👍
table-clear-1k.benchmark:benchmark-table/clear/1k 14.68 (± 0.64 ms) 14.93 (± 0.67 ms) 👌
table-create-10k.benchmark:benchmark-table/create/10k 1555.89 (± 36.16 ms) 1499.61 (± 42.09 ms) 👍
table-create-1k.benchmark:benchmark-table/create/1k 164.91 (± 1.90 ms) 155.06 (± 2.25 ms) 👍
table-update-10th-1k.benchmark:benchmark-table/update-10th/1k 152.28 (± 6.29 ms) 138.47 (± 2.97 ms) 👍
tablecmp-append-1k.benchmark:benchmark-table-component/append/1k 365.19 (± 5.41 ms) 343.33 (± 9.98 ms) 👍
tablecmp-clear-1k.benchmark:benchmark-table/clear/1k 37.10 (± 1.20 ms) 34.81 (± 1.82 ms) 👍
tablecmp-create-10k.benchmark:benchmark-table-component/create/10k 2714.27 (± 35.76 ms) 2495.70 (± 15.89 ms) 👍
tablecmp-create-1k.benchmark:benchmark-table-component/create/1k 305.65 (± 11.89 ms) 274.68 (± 6.72 ms) 👍
tablecmp-update-10th-1k.benchmark:benchmark-table-component/update-10th/1k 153.52 (± 7.32 ms) 140.66 (± 3.97 ms) 👍

@diervo diervo merged commit 7da31a7 into master Mar 15, 2018
@diervo diervo deleted the dval/fixRollupCompat branch March 15, 2018 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants