Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade dependencies #1576

Merged
merged 6 commits into from
Oct 15, 2019
Merged

feat: upgrade dependencies #1576

merged 6 commits into from
Oct 15, 2019

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Oct 14, 2019

Details

Upgrading karma and wdio so the last versions of node work.

Does this PR introduce breaking changes?

  • ✅ No, it does not introduce breaking changes.

pmdartus
pmdartus reviewed Oct 14, 2019
View reviewed changes
Copy link
Member

@pmdartus pmdartus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing because you need to update the reporter name referenced in the karma config.

packages/integration-tests/package.json Outdated Show resolved Hide resolved
@caridy
Copy link
Contributor

caridy commented Oct 14, 2019

still test failures.

ekashida
ekashida reviewed Oct 15, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
ekashida
ekashida approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@ekashida ekashida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@diervo diervo merged commit cc94f9c into master Oct 15, 2019
@diervo diervo deleted the dval/wdioUpdate branch October 15, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmdartus pmdartus pmdartus left review comments

@ekashida ekashida ekashida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diervo @caridy @ekashida @pmdartus