fix(lwc-engine): Add pragma to engine artifacts #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
was this exhibit somewhere? or is this just precaution? |
caridy
reviewed
Mar 15, 2018
| @@ -9,7 +9,7 @@ const entry = path.resolve(__dirname, '../src/framework/main.ts'); | |||
| const commonJSDirectory = path.resolve(__dirname, '../dist/commonjs'); | |||
| const modulesDirectory = path.resolve(__dirname, '../dist/modules'); | |||
|
|
|||
| const banner = (`/**\n * Copyright (C) 2017 salesforce.com, inc.\n */`); | |||
| const banner = (`/* proxy-compat-disable */`); | |||
There was a problem hiding this comment.
you can still keep the salesforce copyright in a secondary line using \n
There was a problem hiding this comment.
I would rather put all the copyrights later as part of the GA effort, because we have different licenses everywhere. I want to debate with legal wether we need the year or not, because its always a pain.
|
@caridy building compat for LDS. But it would also happen in our integration tests if I didn't take it out for perf reasons. |
Benchmark comparisonBase commit:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
When running COMPAT transpilation (in any rollup plugin) guarantee that engine its ignored.
Fix #155