Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wire-service] Remove experimental WireContextEvent event name #1357

Open
caridy opened this issue Jun 16, 2019 · 2 comments
Open

[wire-service] Remove experimental WireContextEvent event name #1357

caridy opened this issue Jun 16, 2019 · 2 comments
Assignees

Comments

@caridy
Copy link
Collaborator

caridy commented Jun 16, 2019

As today, we use an experimental mechanism to provide a dummy-context mechanism. This relies on a magic string value "WireContextEvent" that can be used to dispatch a DOM event from a wire adapter.

This is not longer needed, and should be removed in favor of the formal context mechanism specified here salesforce/lwc-rfcs#6.

@jflowers45
Copy link

Hi, not sure if related, but if debug mode is turned on, any time you wire the CurrentPageReference you get an error. Here's an example that happens in the lwc-recipes.

Invalid event type "WireContextEvent" dispatched in element .

@caridy
Copy link
Collaborator Author

caridy commented Oct 25, 2019

@jflowers45 no, your specific question was answered here: #1591 (comment), and this issue is pending to be closed as soon as we merge #1459, which should happen in the next few days, with that change, there will be no more WireContextEvent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants