Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Babel version mismatch + adding missing dependencies #135

Merged
merged 3 commits into from
Mar 5, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Mar 5, 2018

Details

  • Missing dependencies on packages while releasing npm
  • Fixing missmatch babel version

@diervo
Copy link
Contributor Author

diervo commented Mar 5, 2018

@apapko this fixes your options.loose === undefined throwing issue.

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: a0b5dbf | Target commit: 0e79a33

benchmark base(a0b5dbf) target(0e79a33) trend
table-append-1k.benchmark:benchmark-table/append/1k 269.23 (± 3.78 ms) 272.17 (± 3.88 ms) 👌
table-clear-1k.benchmark:benchmark-table/clear/1k 13.65 (± 0.43 ms) 13.50 (± 0.54 ms) 👌
table-create-10k.benchmark:benchmark-table/create/10k 1492.28 (± 17.53 ms) 1568.45 (± 18.08 ms) 👎
table-create-1k.benchmark:benchmark-table/create/1k 163.48 (± 1.88 ms) 165.56 (± 1.32 ms) 👎
table-update-10th-1k.benchmark:benchmark-table/update-10th/1k 140.80 (± 3.80 ms) 154.88 (± 4.50 ms) 👎
tablecmp-append-1k.benchmark:benchmark-table-component/append/1k 335.50 (± 8.70 ms) 352.49 (± 9.15 ms) 👌
tablecmp-clear-1k.benchmark:benchmark-table/clear/1k 34.84 (± 1.19 ms) 31.65 (± 1.33 ms) 👍
tablecmp-create-10k.benchmark:benchmark-table-component/create/10k 2388.94 (± 24.10 ms) 2302.36 (± 32.64 ms) 👍
tablecmp-create-1k.benchmark:benchmark-table-component/create/1k 262.14 (± 2.84 ms) 258.18 (± 4.60 ms) 👌
tablecmp-update-10th-1k.benchmark:benchmark-table-component/update-10th/1k 140.22 (± 2.22 ms) 143.07 (± 3.08 ms) 👌

@diervo diervo merged commit 055f92e into master Mar 5, 2018
@diervo diervo deleted the dval/missingPkgDeps branch March 5, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant