Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Integration test for compat #134

Merged
merged 2 commits into from
Mar 2, 2018
Merged

fix: Integration test for compat #134

merged 2 commits into from
Mar 2, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Mar 2, 2018

No description provided.

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: c1136a5 | Target commit: ba408cb

benchmark base(c1136a5) target(ba408cb) trend
table-append-1k.benchmark:benchmark-table/append/1k 275.63 (± 4.24 ms) 281.50 (± 7.56 ms) 👌
table-clear-1k.benchmark:benchmark-table/clear/1k 14.08 (± 0.65 ms) 14.18 (± 0.52 ms) 👌
table-create-10k.benchmark:benchmark-table/create/10k 1528.26 (± 18.63 ms) 1551.06 (± 28.69 ms) 👎
table-create-1k.benchmark:benchmark-table/create/1k 163.46 (± 1.35 ms) 171.04 (± 4.76 ms) 👎
table-update-10th-1k.benchmark:benchmark-table/update-10th/1k 145.50 (± 4.62 ms) 149.19 (± 6.91 ms) 👎
tablecmp-append-1k.benchmark:benchmark-table-component/append/1k 374.65 (± 12.82 ms) 384.96 (± 18.21 ms) 👌
tablecmp-clear-1k.benchmark:benchmark-table/clear/1k 36.03 (± 1.82 ms) 38.14 (± 3.28 ms) 👌
tablecmp-create-10k.benchmark:benchmark-table-component/create/10k 2417.64 (± 57.58 ms) 2482.10 (± 40.49 ms) 👎
tablecmp-create-1k.benchmark:benchmark-table-component/create/1k 262.80 (± 3.78 ms) 276.90 (± 10.67 ms) 👎
tablecmp-update-10th-1k.benchmark:benchmark-table-component/update-10th/1k 142.79 (± 3.93 ms) 153.78 (± 7.77 ms) 👎

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: c1136a5 | Target commit: 26c46d7

benchmark base(c1136a5) target(26c46d7) trend
table-append-1k.benchmark:benchmark-table/append/1k 275.63 (± 4.24 ms) 289.83 (± 5.25 ms) 👎
table-clear-1k.benchmark:benchmark-table/clear/1k 14.08 (± 0.65 ms) 15.44 (± 0.80 ms) 👎
table-create-10k.benchmark:benchmark-table/create/10k 1528.26 (± 18.63 ms) 1521.46 (± 17.40 ms) 👌
table-create-1k.benchmark:benchmark-table/create/1k 163.46 (± 1.35 ms) 167.59 (± 2.05 ms) 👎
table-update-10th-1k.benchmark:benchmark-table/update-10th/1k 145.50 (± 4.62 ms) 153.84 (± 3.80 ms) 👎
tablecmp-append-1k.benchmark:benchmark-table-component/append/1k 374.65 (± 12.82 ms) 366.93 (± 18.43 ms) 👌
tablecmp-clear-1k.benchmark:benchmark-table/clear/1k 36.03 (± 1.82 ms) 36.07 (± 1.43 ms) 👌
tablecmp-create-10k.benchmark:benchmark-table-component/create/10k 2417.64 (± 57.58 ms) 2465.74 (± 39.94 ms) 👌
tablecmp-create-1k.benchmark:benchmark-table-component/create/1k 262.80 (± 3.78 ms) 278.54 (± 7.85 ms) 👎
tablecmp-update-10th-1k.benchmark:benchmark-table-component/update-10th/1k 142.79 (± 3.93 ms) 147.72 (± 3.72 ms) 👎

@diervo diervo merged commit d2e2432 into master Mar 2, 2018
@diervo diervo deleted the dval/fixIntegrationTests branch March 2, 2018 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant