Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): remove import locations metadata #1047

Merged
merged 1 commit into from
Feb 21, 2019
Merged

feat(compiler): remove import locations metadata #1047

merged 1 commit into from
Feb 21, 2019

Conversation

apapko
Copy link
Collaborator

@apapko apapko commented Feb 12, 2019

Details

import locations are not surfaced to ModuleDefImpl, which is the final consumer of component metadata. Therefore removing its usage.

Does this PR introduce a breaking change?

  • Yes
  • No

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: f5a3a71 | Target commit: cb4d271

lwc-engine-benchmark

table-append-1k metric base(f5a3a71) target(cb4d271) trend
benchmark-table/append/1k duration 148.40 (±4.55 ms) 151.65 (±4.30 ms) +3.2ms (2.2%) 👎
table-clear-1k metric base(f5a3a71) target(cb4d271) trend
benchmark-table/clear/1k duration 6.05 (±0.35 ms) 6.25 (±0.45 ms) +0.2ms (3.3%) 👎
table-create-10k metric base(f5a3a71) target(cb4d271) trend
benchmark-table/create/10k duration 886.90 (±6.90 ms) 901.30 (±9.45 ms) +14.4ms (1.6%) 👎
table-create-1k metric base(f5a3a71) target(cb4d271) trend
benchmark-table/create/1k duration 117.35 (±3.25 ms) 119.65 (±2.70 ms) +2.3ms (2.0%) 👎
table-update-10th-1k metric base(f5a3a71) target(cb4d271) trend
benchmark-table/update-10th/1k duration 75.70 (±3.50 ms) 75.10 (±2.40 ms) -0.6ms (0.8%) 👌
tablecmp-append-1k metric base(f5a3a71) target(cb4d271) trend
benchmark-table-component/append/1k duration 258.85 (±6.55 ms) 255.90 (±4.65 ms) -3.0ms (1.1%) 👍
tablecmp-clear-1k metric base(f5a3a71) target(cb4d271) trend
benchmark-table-component/clear/1k duration 11.55 (±1.45 ms) 12.30 (±1.50 ms) +0.8ms (6.5%) 👌
tablecmp-create-10k metric base(f5a3a71) target(cb4d271) trend
benchmark-table-component/create/10k duration 1793.30 (±18.55 ms) 1812.75 (±20.20 ms) +19.4ms (1.1%) 👎
tablecmp-create-1k metric base(f5a3a71) target(cb4d271) trend
benchmark-table-component/create/1k duration 213.60 (±3.30 ms) 213.60 (±5.55 ms) 0.0ms (0.0%) 👌
tablecmp-update-10th-1k metric base(f5a3a71) target(cb4d271) trend
benchmark-table-component/update-10th/1k duration 73.35 (±5.50 ms) 69.20 (±5.30 ms) -4.1ms (5.7%) 👌
wc-append-1k metric base(f5a3a71) target(cb4d271) trend
benchmark-table-wc/append/1k duration 260.15 (±7.10 ms) 259.15 (±6.10 ms) -1.0ms (0.4%) 👌
wc-clear-1k metric base(f5a3a71) target(cb4d271) trend
benchmark-table-wc/clear/1k duration 22.90 (±2.25 ms) 23.00 (±2.25 ms) +0.1ms (0.4%) 👌
wc-create-10k metric base(f5a3a71) target(cb4d271) trend
benchmark-table-wc/create/10k duration 2027.80 (±14.65 ms) 2039.95 (±25.70 ms) +12.1ms (0.6%) 👎
wc-create-1k metric base(f5a3a71) target(cb4d271) trend
benchmark-table-wc/create/1k duration 229.30 (±6.55 ms) 228.55 (±5.15 ms) -0.8ms (0.3%) 👌
wc-update-10th-1k metric base(f5a3a71) target(cb4d271) trend
benchmark-table-wc/update-10th/1k duration 68.00 (±5.15 ms) 68.05 (±4.45 ms) +0.0ms (0.1%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 3617361 | Target commit: cb4d271

lwc-engine-benchmark

table-append-1k metric base(3617361) target(cb4d271) trend
benchmark-table/append/1k duration 151.50 (±5.00 ms) 154.30 (±5.25 ms) +2.8ms (1.8%) 👎
table-clear-1k metric base(3617361) target(cb4d271) trend
benchmark-table/clear/1k duration 6.00 (±0.30 ms) 6.70 (±0.40 ms) +0.7ms (11.7%) 👎
table-create-10k metric base(3617361) target(cb4d271) trend
benchmark-table/create/10k duration 881.65 (±5.90 ms) 894.75 (±8.70 ms) +13.1ms (1.5%) 👎
table-create-1k metric base(3617361) target(cb4d271) trend
benchmark-table/create/1k duration 118.35 (±2.70 ms) 118.65 (±2.30 ms) +0.3ms (0.3%) 👌
table-update-10th-1k metric base(3617361) target(cb4d271) trend
benchmark-table/update-10th/1k duration 76.75 (±3.80 ms) 85.85 (±1.95 ms) +9.1ms (11.9%) 👎
tablecmp-append-1k metric base(3617361) target(cb4d271) trend
benchmark-table-component/append/1k duration 222.80 (±11.30 ms) 232.15 (±18.70 ms) +9.3ms (4.2%) 👎
tablecmp-clear-1k metric base(3617361) target(cb4d271) trend
benchmark-table-component/clear/1k duration 12.65 (±1.85 ms) 12.45 (±1.75 ms) -0.2ms (1.6%) 👌
tablecmp-create-10k metric base(3617361) target(cb4d271) trend
benchmark-table-component/create/10k duration 1810.25 (±10.05 ms) 1808.90 (±14.65 ms) -1.3ms (0.1%) 👌
tablecmp-create-1k metric base(3617361) target(cb4d271) trend
benchmark-table-component/create/1k duration 216.75 (±7.55 ms) 213.10 (±4.70 ms) -3.7ms (1.7%) 👌
tablecmp-update-10th-1k metric base(3617361) target(cb4d271) trend
benchmark-table-component/update-10th/1k duration 67.60 (±4.25 ms) 68.85 (±4.95 ms) +1.3ms (1.8%) 👌
wc-append-1k metric base(3617361) target(cb4d271) trend
benchmark-table-wc/append/1k duration 259.30 (±6.55 ms) 261.90 (±7.75 ms) +2.6ms (1.0%) 👌
wc-clear-1k metric base(3617361) target(cb4d271) trend
benchmark-table-wc/clear/1k duration 22.65 (±2.45 ms) 22.25 (±2.25 ms) -0.4ms (1.8%) 👌
wc-create-10k metric base(3617361) target(cb4d271) trend
benchmark-table-wc/create/10k duration 2047.90 (±18.50 ms) 2045.55 (±15.45 ms) -2.3ms (0.1%) 👌
wc-create-1k metric base(3617361) target(cb4d271) trend
benchmark-table-wc/create/1k duration 234.10 (±4.95 ms) 230.20 (±4.85 ms) -3.9ms (1.7%) 👌
wc-update-10th-1k metric base(3617361) target(cb4d271) trend
benchmark-table-wc/update-10th/1k duration 73.20 (±5.70 ms) 71.40 (±5.40 ms) -1.8ms (2.5%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 3617361 | Target commit: cb4d271

lwc-engine-benchmark

table-append-1k metric base(3617361) target(cb4d271) trend
benchmark-table/append/1k duration 151.50 (±5.00 ms) 153.60 (±4.90 ms) +2.1ms (1.4%) 👎
table-clear-1k metric base(3617361) target(cb4d271) trend
benchmark-table/clear/1k duration 6.00 (±0.30 ms) 6.20 (±0.40 ms) +0.2ms (3.3%) 👌
table-create-10k metric base(3617361) target(cb4d271) trend
benchmark-table/create/10k duration 881.65 (±5.90 ms) 879.70 (±7.55 ms) -1.9ms (0.2%) 👌
table-create-1k metric base(3617361) target(cb4d271) trend
benchmark-table/create/1k duration 118.35 (±2.70 ms) 118.65 (±2.35 ms) +0.3ms (0.3%) 👌
table-update-10th-1k metric base(3617361) target(cb4d271) trend
benchmark-table/update-10th/1k duration 76.75 (±3.80 ms) 85.25 (±1.25 ms) +8.5ms (11.1%) 👎
tablecmp-append-1k metric base(3617361) target(cb4d271) trend
benchmark-table-component/append/1k duration 222.80 (±11.30 ms) 255.30 (±4.70 ms) +32.5ms (14.6%) 👎
tablecmp-clear-1k metric base(3617361) target(cb4d271) trend
benchmark-table-component/clear/1k duration 12.65 (±1.85 ms) 11.90 (±1.60 ms) -0.7ms (5.9%) 👌
tablecmp-create-10k metric base(3617361) target(cb4d271) trend
benchmark-table-component/create/10k duration 1810.25 (±10.05 ms) 1782.65 (±12.35 ms) -27.6ms (1.5%) 👍
tablecmp-create-1k metric base(3617361) target(cb4d271) trend
benchmark-table-component/create/1k duration 216.75 (±7.55 ms) 212.80 (±5.25 ms) -3.9ms (1.8%) 👍
tablecmp-update-10th-1k metric base(3617361) target(cb4d271) trend
benchmark-table-component/update-10th/1k duration 67.60 (±4.25 ms) 70.10 (±4.45 ms) +2.5ms (3.7%) 👎
wc-append-1k metric base(3617361) target(cb4d271) trend
benchmark-table-wc/append/1k duration 259.30 (±6.55 ms) 264.90 (±5.25 ms) +5.6ms (2.2%) 👎
wc-clear-1k metric base(3617361) target(cb4d271) trend
benchmark-table-wc/clear/1k duration 22.65 (±2.45 ms) 22.85 (±2.05 ms) +0.2ms (0.9%) 👌
wc-create-10k metric base(3617361) target(cb4d271) trend
benchmark-table-wc/create/10k duration 2047.90 (±18.50 ms) 2039.30 (±17.85 ms) -8.6ms (0.4%) 👌
wc-create-1k metric base(3617361) target(cb4d271) trend
benchmark-table-wc/create/1k duration 234.10 (±4.95 ms) 223.05 (±6.60 ms) -11.1ms (4.7%) 👍
wc-update-10th-1k metric base(3617361) target(cb4d271) trend
benchmark-table-wc/update-10th/1k duration 73.20 (±5.70 ms) 70.55 (±5.05 ms) -2.6ms (3.6%) 👌

@apapko apapko force-pushed the apapko/meta-remove-import-locations branch from cb4d271 to d98f837 Compare February 13, 2019 23:21
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 3617361 | Target commit: d98f837

lwc-engine-benchmark

table-append-1k metric base(3617361) target(d98f837) trend
benchmark-table/append/1k duration 151.50 (±5.00 ms) 150.05 (±4.50 ms) -1.4ms (1.0%) 👌
table-clear-1k metric base(3617361) target(d98f837) trend
benchmark-table/clear/1k duration 6.00 (±0.30 ms) 6.20 (±0.50 ms) +0.2ms (3.3%) 👌
table-create-10k metric base(3617361) target(d98f837) trend
benchmark-table/create/10k duration 881.65 (±5.90 ms) 884.80 (±7.75 ms) +3.1ms (0.4%) 👎
table-create-1k metric base(3617361) target(d98f837) trend
benchmark-table/create/1k duration 118.35 (±2.70 ms) 118.50 (±2.25 ms) +0.2ms (0.1%) 👌
table-update-10th-1k metric base(3617361) target(d98f837) trend
benchmark-table/update-10th/1k duration 76.75 (±3.80 ms) 74.40 (±2.00 ms) -2.3ms (3.1%) 👍
tablecmp-append-1k metric base(3617361) target(d98f837) trend
benchmark-table-component/append/1k duration 222.80 (±11.30 ms) 247.65 (±8.65 ms) +24.8ms (11.2%) 👎
tablecmp-clear-1k metric base(3617361) target(d98f837) trend
benchmark-table-component/clear/1k duration 12.65 (±1.85 ms) 11.75 (±1.75 ms) -0.9ms (7.1%) 👌
tablecmp-create-10k metric base(3617361) target(d98f837) trend
benchmark-table-component/create/10k duration 1810.25 (±10.05 ms) 1799.60 (±15.00 ms) -10.7ms (0.6%) 👍
tablecmp-create-1k metric base(3617361) target(d98f837) trend
benchmark-table-component/create/1k duration 216.75 (±7.55 ms) 214.15 (±6.10 ms) -2.6ms (1.2%) 👌
tablecmp-update-10th-1k metric base(3617361) target(d98f837) trend
benchmark-table-component/update-10th/1k duration 67.60 (±4.25 ms) 69.70 (±5.00 ms) +2.1ms (3.1%) 👌
wc-append-1k metric base(3617361) target(d98f837) trend
benchmark-table-wc/append/1k duration 259.30 (±6.55 ms) 255.85 (±5.45 ms) -3.4ms (1.3%) 👍
wc-clear-1k metric base(3617361) target(d98f837) trend
benchmark-table-wc/clear/1k duration 22.65 (±2.45 ms) 22.90 (±2.45 ms) +0.3ms (1.1%) 👌
wc-create-10k metric base(3617361) target(d98f837) trend
benchmark-table-wc/create/10k duration 2047.90 (±18.50 ms) 2025.80 (±17.00 ms) -22.1ms (1.1%) 👍
wc-create-1k metric base(3617361) target(d98f837) trend
benchmark-table-wc/create/1k duration 234.10 (±4.95 ms) 231.40 (±5.20 ms) -2.7ms (1.2%) 👌
wc-update-10th-1k metric base(3617361) target(d98f837) trend
benchmark-table-wc/update-10th/1k duration 73.20 (±5.70 ms) 69.75 (±5.80 ms) -3.5ms (4.7%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 3617361 | Target commit: d98f837

lwc-engine-benchmark

table-append-1k metric base(3617361) target(d98f837) trend
benchmark-table/append/1k duration 151.50 (±5.00 ms) 151.90 (±5.05 ms) +0.4ms (0.3%) 👌
table-clear-1k metric base(3617361) target(d98f837) trend
benchmark-table/clear/1k duration 6.00 (±0.30 ms) 6.25 (±0.35 ms) +0.3ms (4.2%) 👌
table-create-10k metric base(3617361) target(d98f837) trend
benchmark-table/create/10k duration 881.65 (±5.90 ms) 898.25 (±5.95 ms) +16.6ms (1.9%) 👎
table-create-1k metric base(3617361) target(d98f837) trend
benchmark-table/create/1k duration 118.35 (±2.70 ms) 120.50 (±3.30 ms) +2.2ms (1.8%) 👎
table-update-10th-1k metric base(3617361) target(d98f837) trend
benchmark-table/update-10th/1k duration 76.75 (±3.80 ms) 73.60 (±2.30 ms) -3.2ms (4.1%) 👍
tablecmp-append-1k metric base(3617361) target(d98f837) trend
benchmark-table-component/append/1k duration 222.80 (±11.30 ms) 253.00 (±6.80 ms) +30.2ms (13.6%) 👎
tablecmp-clear-1k metric base(3617361) target(d98f837) trend
benchmark-table-component/clear/1k duration 12.65 (±1.85 ms) 12.60 (±2.10 ms) -0.0ms (0.4%) 👌
tablecmp-create-10k metric base(3617361) target(d98f837) trend
benchmark-table-component/create/10k duration 1810.25 (±10.05 ms) 1786.15 (±12.95 ms) -24.1ms (1.3%) 👍
tablecmp-create-1k metric base(3617361) target(d98f837) trend
benchmark-table-component/create/1k duration 216.75 (±7.55 ms) 216.70 (±4.45 ms) -0.1ms (0.0%) 👌
tablecmp-update-10th-1k metric base(3617361) target(d98f837) trend
benchmark-table-component/update-10th/1k duration 67.60 (±4.25 ms) 69.95 (±5.10 ms) +2.4ms (3.5%) 👌
wc-append-1k metric base(3617361) target(d98f837) trend
benchmark-table-wc/append/1k duration 259.30 (±6.55 ms) 259.75 (±5.55 ms) +0.4ms (0.2%) 👌
wc-clear-1k metric base(3617361) target(d98f837) trend
benchmark-table-wc/clear/1k duration 22.65 (±2.45 ms) 22.35 (±2.15 ms) -0.3ms (1.3%) 👌
wc-create-10k metric base(3617361) target(d98f837) trend
benchmark-table-wc/create/10k duration 2047.90 (±18.50 ms) 2015.00 (±16.25 ms) -32.9ms (1.6%) 👍
wc-create-1k metric base(3617361) target(d98f837) trend
benchmark-table-wc/create/1k duration 234.10 (±4.95 ms) 231.45 (±5.25 ms) -2.7ms (1.1%) 👌
wc-update-10th-1k metric base(3617361) target(d98f837) trend
benchmark-table-wc/update-10th/1k duration 73.20 (±5.70 ms) 70.70 (±5.30 ms) -2.5ms (3.4%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 3617361 | Target commit: d98f837

lwc-engine-benchmark

table-append-1k metric base(3617361) target(d98f837) trend
benchmark-table/append/1k duration 151.50 (±5.00 ms) 149.25 (±3.50 ms) -2.3ms (1.5%) 👌
table-clear-1k metric base(3617361) target(d98f837) trend
benchmark-table/clear/1k duration 6.00 (±0.30 ms) 6.20 (±0.40 ms) +0.2ms (3.3%) 👌
table-create-10k metric base(3617361) target(d98f837) trend
benchmark-table/create/10k duration 881.65 (±5.90 ms) 886.65 (±5.75 ms) +5.0ms (0.6%) 👎
table-create-1k metric base(3617361) target(d98f837) trend
benchmark-table/create/1k duration 118.35 (±2.70 ms) 118.70 (±3.20 ms) +0.4ms (0.3%) 👌
table-update-10th-1k metric base(3617361) target(d98f837) trend
benchmark-table/update-10th/1k duration 76.75 (±3.80 ms) 77.45 (±5.75 ms) +0.7ms (0.9%) 👌
tablecmp-append-1k metric base(3617361) target(d98f837) trend
benchmark-table-component/append/1k duration 222.80 (±11.30 ms) 253.90 (±5.10 ms) +31.1ms (14.0%) 👎
tablecmp-clear-1k metric base(3617361) target(d98f837) trend
benchmark-table-component/clear/1k duration 12.65 (±1.85 ms) 11.95 (±1.50 ms) -0.7ms (5.5%) 👌
tablecmp-create-10k metric base(3617361) target(d98f837) trend
benchmark-table-component/create/10k duration 1810.25 (±10.05 ms) 1807.85 (±14.65 ms) -2.4ms (0.1%) 👌
tablecmp-create-1k metric base(3617361) target(d98f837) trend
benchmark-table-component/create/1k duration 216.75 (±7.55 ms) 218.60 (±5.65 ms) +1.8ms (0.9%) 👌
tablecmp-update-10th-1k metric base(3617361) target(d98f837) trend
benchmark-table-component/update-10th/1k duration 67.60 (±4.25 ms) 69.25 (±4.30 ms) +1.7ms (2.4%) 👌
wc-append-1k metric base(3617361) target(d98f837) trend
benchmark-table-wc/append/1k duration 259.30 (±6.55 ms) 260.20 (±6.90 ms) +0.9ms (0.3%) 👌
wc-clear-1k metric base(3617361) target(d98f837) trend
benchmark-table-wc/clear/1k duration 22.65 (±2.45 ms) 22.25 (±2.10 ms) -0.4ms (1.8%) 👌
wc-create-10k metric base(3617361) target(d98f837) trend
benchmark-table-wc/create/10k duration 2047.90 (±18.50 ms) 2018.10 (±13.25 ms) -29.8ms (1.5%) 👍
wc-create-1k metric base(3617361) target(d98f837) trend
benchmark-table-wc/create/1k duration 234.10 (±4.95 ms) 231.85 (±5.40 ms) -2.3ms (1.0%) 👌
wc-update-10th-1k metric base(3617361) target(d98f837) trend
benchmark-table-wc/update-10th/1k duration 73.20 (±5.70 ms) 69.65 (±7.10 ms) -3.5ms (4.8%) 👌

@apapko apapko force-pushed the apapko/meta-remove-import-locations branch from d98f837 to 5052831 Compare February 21, 2019 16:40
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 4148c0e | Target commit: 5052831

lwc-engine-benchmark

table-append-1k metric base(4148c0e) target(5052831) trend
benchmark-table/append/1k duration 152.40 (±4.00 ms) 150.85 (±4.00 ms) -1.5ms (1.0%) 👌
table-clear-1k metric base(4148c0e) target(5052831) trend
benchmark-table/clear/1k duration 6.55 (±0.35 ms) 5.90 (±0.35 ms) -0.6ms (9.9%) 👍
table-create-10k metric base(4148c0e) target(5052831) trend
benchmark-table/create/10k duration 888.55 (±7.90 ms) 891.80 (±5.95 ms) +3.3ms (0.4%) 👌
table-create-1k metric base(4148c0e) target(5052831) trend
benchmark-table/create/1k duration 117.75 (±2.80 ms) 118.85 (±2.80 ms) +1.1ms (0.9%) 👌
table-update-10th-1k metric base(4148c0e) target(5052831) trend
benchmark-table/update-10th/1k duration 83.85 (±4.25 ms) 74.80 (±3.65 ms) -9.0ms (10.8%) 👍
tablecmp-append-1k metric base(4148c0e) target(5052831) trend
benchmark-table-component/append/1k duration 239.50 (±15.15 ms) 253.65 (±5.70 ms) +14.1ms (5.9%) 👎
tablecmp-clear-1k metric base(4148c0e) target(5052831) trend
benchmark-table-component/clear/1k duration 11.40 (±1.65 ms) 11.90 (±1.50 ms) +0.5ms (4.4%) 👌
tablecmp-create-10k metric base(4148c0e) target(5052831) trend
benchmark-table-component/create/10k duration 1803.15 (±15.65 ms) 1786.90 (±17.05 ms) -16.3ms (0.9%) 👍
tablecmp-create-1k metric base(4148c0e) target(5052831) trend
benchmark-table-component/create/1k duration 221.95 (±6.70 ms) 214.05 (±7.10 ms) -7.9ms (3.6%) 👍
tablecmp-update-10th-1k metric base(4148c0e) target(5052831) trend
benchmark-table-component/update-10th/1k duration 68.55 (±4.60 ms) 70.00 (±4.50 ms) +1.5ms (2.1%) 👌
wc-append-1k metric base(4148c0e) target(5052831) trend
benchmark-table-wc/append/1k duration 258.30 (±4.25 ms) 254.90 (±4.95 ms) -3.4ms (1.3%) 👍
wc-clear-1k metric base(4148c0e) target(5052831) trend
benchmark-table-wc/clear/1k duration 22.45 (±2.90 ms) 22.15 (±2.55 ms) -0.3ms (1.3%) 👌
wc-create-10k metric base(4148c0e) target(5052831) trend
benchmark-table-wc/create/10k duration 2057.90 (±19.05 ms) 2085.45 (±13.50 ms) +27.6ms (1.3%) 👎
wc-create-1k metric base(4148c0e) target(5052831) trend
benchmark-table-wc/create/1k duration 229.70 (±3.95 ms) 228.25 (±5.50 ms) -1.4ms (0.6%) 👌
wc-update-10th-1k metric base(4148c0e) target(5052831) trend
benchmark-table-wc/update-10th/1k duration 72.45 (±6.75 ms) 68.85 (±4.40 ms) -3.6ms (5.0%) 👌

@apapko apapko merged commit 80e6816 into master Feb 21, 2019
@apapko apapko deleted the apapko/meta-remove-import-locations branch February 21, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmdartus pmdartus pmdartus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apapko @pmdartus