Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): Validate decorated properties #101

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

pmdartus
Copy link
Member

Details

This PR fixes a bug in the babel-plugin-transform-lwc-class where decorators applied to class fields where not validated the same way than class methods.

Fixes #100

Does this PR introduce a breaking change?

  • Yes
  • No

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: 9a57344 | Target commit: 5cbe9f2

benchmark base(9a57344) target(5cbe9f2) trend
table-append-1k.benchmark:benchmark-table/append/1k 250.74 (± 4.78 ms) 250.71 (± 7.57 ms) 👌
table-clear-1k.benchmark:benchmark-table/clear/1k 12.94 (± 0.61 ms) 13.26 (± 0.58 ms) 👌
table-create-10k.benchmark:benchmark-table/create/10k 1373.61 (± 11.19 ms) 1391.38 (± 12.18 ms) 👎
table-create-1k.benchmark:benchmark-table/create/1k 141.81 (± 3.05 ms) 150.00 (± 2.60 ms) 👎
table-update-10th-1k.benchmark:benchmark-table/update-10th/1k 143.01 (± 2.77 ms) 140.25 (± 1.66 ms) 👍
tablecmp-append-1k.benchmark:benchmark-table-component/append/1k 320.67 (± 9.22 ms) 315.57 (± 7.11 ms) 👍
tablecmp-clear-1k.benchmark:benchmark-table/clear/1k 30.69 (± 1.08 ms) 30.95 (± 1.06 ms) 👌
tablecmp-create-10k.benchmark:benchmark-table-component/create/10k 1980.69 (± 24.34 ms) 2079.30 (± 62.79 ms) 👎
tablecmp-create-1k.benchmark:benchmark-table-component/create/1k 227.68 (± 6.53 ms) 227.04 (± 3.96 ms) 👌
tablecmp-update-10th-1k.benchmark:benchmark-table-component/update-10th/1k 134.20 (± 2.27 ms) 137.38 (± 4.07 ms) 👎

@diervo diervo merged commit d50e217 into master Feb 14, 2018
@diervo diervo deleted the pmdartus/compiler-validate-decorated-properties branch February 14, 2018 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler doesn't validate usage of decorators on class fields
2 participants