From 0fc593761785db560998dd152e15aa3977815a7c Mon Sep 17 00:00:00 2001 From: Ravi Jayaramappa Date: Mon, 13 Jan 2020 16:14:06 -0800 Subject: [PATCH] test: remove test for removing non-existent listener on custom element --- .../index.spec.js | 17 ----------------- .../nonExistingEventListener.js | 7 ------- 2 files changed, 24 deletions(-) delete mode 100644 packages/integration-karma/test/component/LightningElement.removeEventListener/x/nonExistingEventListener/nonExistingEventListener.js diff --git a/packages/integration-karma/test/component/LightningElement.removeEventListener/index.spec.js b/packages/integration-karma/test/component/LightningElement.removeEventListener/index.spec.js index 91342117be..1866693448 100644 --- a/packages/integration-karma/test/component/LightningElement.removeEventListener/index.spec.js +++ b/packages/integration-karma/test/component/LightningElement.removeEventListener/index.spec.js @@ -2,7 +2,6 @@ import { createElement } from 'lwc'; import Test from 'x/test'; import LifecycleHooks from 'x/lifecycleHooks'; -import NonExistingEventListener from 'x/nonExistingEventListener'; it('should remove existing event listeners', () => { let isInvoked = false; @@ -31,19 +30,3 @@ it('should not throw when invoking in the different lifecycle hooks', () => { document.body.removeChild(elm); }).not.toThrow(); }); - -// TODO [#1043]: inconsistent restriction between native shadow and synthetic shadow -xit('should log an error message when removing a non existing event handler', () => { - const elm = createElement('x-non-existing-event-listener', { is: NonExistingEventListener }); - - spyOn(console, 'error'); - document.body.appendChild(elm); - - /* eslint-disable-next-line no-console */ - expect(console.error).toHaveBeenCalledTimes(1); - - /* eslint-disable-next-line no-console */ - expect(console.error.calls.argsFor(0)[0]).toMatch( - /\[LWC error\]: Did not find event listener for event "click" executing removeEventListener on \[object HTMLElement\]. This is probably a typo or a life cycle mismatch. Make sure that you add the right event listeners in the connectedCallback\(\) hook and remove them in the disconnectedCallback\(\) hook./ - ); -}); diff --git a/packages/integration-karma/test/component/LightningElement.removeEventListener/x/nonExistingEventListener/nonExistingEventListener.js b/packages/integration-karma/test/component/LightningElement.removeEventListener/x/nonExistingEventListener/nonExistingEventListener.js deleted file mode 100644 index 77b10d4d08..0000000000 --- a/packages/integration-karma/test/component/LightningElement.removeEventListener/x/nonExistingEventListener/nonExistingEventListener.js +++ /dev/null @@ -1,7 +0,0 @@ -import { LightningElement } from 'lwc'; - -export default class NonExistingEventListener extends LightningElement { - connectedCallback() { - this.removeEventListener('click', () => {}); - } -}