Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing error message in ModelSelectorSummary#evalMetFromJson #379

Closed
gerashegalov opened this issue Aug 5, 2019 · 0 comments · Fixed by #380
Closed

Confusing error message in ModelSelectorSummary#evalMetFromJson #379

gerashegalov opened this issue Aug 5, 2019 · 0 comments · Fixed by #380

Comments

@gerashegalov
Copy link
Contributor

gerashegalov commented Aug 5, 2019

Describe the bug
def error produces a confusing string by calling mkString on a string json.mkString(",")
Moreover it swallows the root cause exceptions needed for debugging and fixing.

To Reproduce
inject corrupt metric json

Expected behavior
original text leading to the serde exception, and the entire cause chain

Logs or screenshots

java.lang.IllegalArgumentException: Could not extract metrics of type class com.salesforce.op.evaluators.MultiMetrics from {,",m,e,t,r,i,c,s,",:,{,",m,u,l,t,i,c,l,a,s,s, ,e,v,a,l,u,a,t,i,o,n, 
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant