Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala-graph library to eliminate scalacheck from runtime #105

Closed
alkersan opened this issue Aug 30, 2018 · 1 comment
Closed

Update scala-graph library to eliminate scalacheck from runtime #105

alkersan opened this issue Aug 30, 2018 · 1 comment

Comments

@alkersan
Copy link

Problem
features module at the moment is using scala-graph 1.11.2 library, which has transitive dependency on scalacheck testing library, but not in the test or optional scope. Probably it was a minor mistake in the early days of scala-graph development, which was fixed quite long ago. From the end-user perspective this might be suspicious at minimum, e.g. my first question during dependency troubleshooting and spark job assembly building was: what this test dependency is doing in the runtime?

image

Solution
The aforementioned fix is available since 1.11.4, while the last version in the 1.11 branch is 1.11.5.
Solution might be as simple as bumping the scalaGraphVersion, thus reducing dependency tree a bit and simplifying the assembly building for the users.

@tovbinm
Copy link
Collaborator

tovbinm commented Aug 30, 2018

@alkersan thank you for pointing this out. I will make a PR with the version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants