This repository has been archived by the owner on Jan 20, 2024. It is now read-only.
Fix PHP 7.4 bug #159 #160
Open
Fix PHP 7.4 bug #159 #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be rebased on the latest instead of the 1.2.2 version? Also, this change could be added, since it's for the same reason. It's confirmed by the existing |
|
Actually this change as well. |
|
Hi, what is missing to merge this? Could I help with something to get this merged? |
|
I have the same issue. Changes looks well 👍 |
|
Any news on getting this merged? |
|
Yes, I would certainly benefit from this fix. |
|
@manivinesh @sfdrogojan could you guys help us with that? |
|
can someone please merge this PR to master branch, as we need this fix asap |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the reformatting this was really only a few changes to fix #159 by changing several instances of:
to
and initializing $this->tenantTokens in the constructor instead of a local variable.