Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password validation errors are not shown #468

Closed
maarcingebala opened this issue Apr 6, 2020 · 2 comments · Fixed by #471
Closed

Password validation errors are not shown #468

maarcingebala opened this issue Apr 6, 2020 · 2 comments · Fixed by #471
Labels
bug Something isn't working

Comments

@maarcingebala
Copy link
Member

What I'm trying to achieve

To set password as a new staff user.

Steps to reproduce the problem

  1. Create a new staff user through the dashboard.
  2. Receive an email with the link to set up password and click it.
  3. Provide a password that doesn't validate against password rules, e.g. too short.

What I expected to happen

To see a validation error.

Screenshots

image

@maarcingebala maarcingebala added the bug Something isn't working label Apr 6, 2020
@maarcingebala
Copy link
Member Author

Errors in the token field are also not rendered:

{"data": {"setPassword": {"errors": [{"code": "INVALID", "field": "token", "__typename": "AccountError"}], "token": null, "user": null, "__typename": "SetPassword"}}}

@gabmartinez
Copy link
Contributor

Hi @maarcingebala, I sent a PR to display the validation errors for the password field. I see now it must include the token field too. I can try to display that error.

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants