Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uploading multiple images at a time #241

Closed
khalibloo opened this issue Nov 5, 2019 · 2 comments · Fixed by #277
Closed

Allow uploading multiple images at a time #241

khalibloo opened this issue Nov 5, 2019 · 2 comments · Fixed by #277

Comments

@khalibloo
Copy link
Contributor

What I'm trying to achieve

Upload multiple product images at a time, either through drag and drop or the file explorer. The new dashboard currently does not allow that. Even if multiple images are dropped into the widget, only 1 is uploaded.

Describe a proposed solution

The old dashboard allowed uploading multiple product images in one go. That would be useful to have in this dashboard as well.

@maarcingebala
Copy link
Member

Hey, we'll look into this. API supports uploading files one by one, but I think it would make sense it the context of image upload to send each file in a separate mutation.

@khalibloo
Copy link
Contributor Author

I agree, keeping each upload as a separate mutation would make it easier to handle errors too. An error in one wouldn't cause all the uploads to fail. It should be up to the UI to queue the uploads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants