Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on eval mode, ground truth labels are concatenated with image_features! #19

Open
hannahgym opened this issue Mar 24, 2021 · 2 comments
Open

Comments

@hannahgym
Copy link

hannahgym commented Mar 24, 2021

here code , ground truth labels are passed to the model on eval mode!!!!

could you please correct me if i am wrong?

thanks.

@katelyn98
Copy link

The ids are only used to generate the results dictionary in eval mode, the ids are not being passed into the model.generate_sentence call. See line here in lcrn_trainer.py

@katelyn98
Copy link

Sorry, nevermind...you are right. The ground truth labels are appended to the image features and passed into the evaluation....not sure where to go from here then...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants