Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] typo in download_geodb_file #224

Open
nick-youngblut opened this issue Nov 3, 2024 · 3 comments
Open

[BUG] typo in download_geodb_file #224

nick-youngblut opened this issue Nov 3, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@nick-youngblut
Copy link

 "{} already exists! Set `overwrite=True` to redownload.".forma(
                download_location
            )

should be:

 "{} already exists! Set `overwrite=True` to redownload.".format(
                download_location
            )

...or just

f"{download_location} already exists! Set `overwrite=True` to redownload."
@nick-youngblut nick-youngblut added the bug Something isn't working label Nov 3, 2024
@saketkc
Copy link
Owner

saketkc commented Nov 3, 2024

Thanks very much @nick-youngblut! Shoul be able to fix it, but would you like to make a PR?

@nick-youngblut
Copy link
Author

Given that it's a minor typo, it would be faster for you. If I would make a PR, I'd look over the code and make more changes (e.g., .format() => f"").

@saketkc
Copy link
Owner

saketkc commented Nov 3, 2024

That code is no longer used (explains why this was not caught earlier). It has not been use since pysradb 1.0 was released (~4 years ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants