Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastq's URLs are empty #209

Open
NomiCentarix opened this issue Jan 15, 2024 · 2 comments
Open

fastq's URLs are empty #209

NomiCentarix opened this issue Jan 15, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@NomiCentarix
Copy link

Describe the bug
The columns "ena_fastq_http", "ena_fastq_http" and "ena_fastq_http" are all NA.
I tested the code in several environments, and no change.
(the data does exist in the same path as before
http://ftp.sra.ebi.ac.uk/vol1/fastq/SRR236/077/SRR23630177/SRR23630177_1.fastq.gz)

To Reproduce

from pysradb.sraweb import SRAweb

db = SRAweb()
gse_to_srp = db.gse_to_srp("GSE226189")
print("gse_to_srp shape:", gse_to_srp.shape)
display(gse_to_srp.head(2))

metadata = db.sra_metadata(gse_to_srp["study_accession"].to_list(), detailed=True)
print(metadata.shape)
display(metadata.head(2))

Desktop (please complete the following information):

  • OS: [e.g. Ubuntu 20.04]
  • Python version [e.g. 3.8]

thanks

@NomiCentarix NomiCentarix added the bug Something isn't working label Jan 15, 2024
@saketkc
Copy link
Owner

saketkc commented Jan 16, 2024

Thanks for the bug report. It is possible something has changed at the EBI end. I will try to check.

@marcomoretto
Copy link

I think the bug is related to the concurrent part here

with concurrent.futures.ThreadPoolExecutor(max_workers=5) as executor:

Calling fetch_ena_fastq works as expected and retrieve the correct URLs

from pysradb.sraweb import SRAweb
db = SRAweb()
db.fetch_ena_fastq("SRP059263")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants