cleaning up directories with spaces in pathnames

[tony-travis]

The "rmlint.sh" script fails when cleaning up empty folders with spaces in the pathname while removing duplicates if the "-c" option is selected, because the shell quoting "$(ls -A $DIR)" does not apply to the "$DIR" folder name.

Under Linux, the while loop can be replaced by a recursive "rmdir":

diff --git a/lib/formats/sh.sh b/lib/formats/sh.sh
index 39f3441..887b65b 100644
--- a/lib/formats/sh.sh
+++ b/lib/formats/sh.sh
@@ -235,10 +235,7 @@ remove_cmd() {
    
             if [ ! -z "$DO_DELETE_EMPTY_DIRS" ]; then
                 DIR=$(dirname "$1")
-                while [ ! "$(ls -A $DIR)" ]; do
-                    rmdir "$DIR"
-                    DIR=$(dirname "$DIR")
-                done
+                rmdir -p --ignore-fail-on-non-empty "$DIR"
             fi
         fi
     fi

[SeeSpotRun]

Thanks, neat solution. Although --ignore-fail-on-non-empty might not work on BSD.

[beespark]

Nested quotes around "$DIR" work inside the $() command substitution:

while [ ! "$(ls -A "$DIR")" ]; do

... and should be POSIX compliant (double-quotes can be nested with command substitution).

[tony-travis]

Thanks, this is what it looks like now:

diff --git a/lib/formats/sh.sh b/lib/formats/sh.sh
index 39f3441..6a23983 100644
--- a/lib/formats/sh.sh
+++ b/lib/formats/sh.sh
@@ -235,7 +235,7 @@ remove_cmd() {

         if [ ! -z "$DO_DELETE_EMPTY_DIRS" ]; then
               DIR=$(dirname "$1")
-              while [ ! "$(ls -A $DIR)" ]; do
+              while [ ! "$(ls -A "$DIR")" ]; do
                  rmdir "$DIR"
                  DIR=$(dirname "$DIR")
               done

[SeeSpotRun]

Actually this was fixed some time back in develop branch but just hadn't made it to master: c9f5eaa

[loikun]

Note the patch has still not made it to the master branch on april 18.
Nested quote solves the issue on removal of directory with whitespace on os X.

[sahib]

@loikun: Thanks for the hint; created a new release now (v2.7.0) which includes this fix.