auth/sso: make it possible to have a single SSO for every account #7709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haraldschilly
changed the title
… email address already exists
haraldschilly
force-pushed
the
sso-exclusive-all
branch
6 times, most recently
from
efe9741
to
cfd15fc
Compare
…ng the email_address is allowed or if update_on_login is set, additionally prohibit changing first or last name
haraldschilly
force-pushed
the
sso-exclusive-all
branch
from
cfd15fc
to
9e5bf97
Compare
…hers match) – and write tests to nail this down
haraldschilly
force-pushed
the
sso-exclusive-all
branch
from
f024662
to
d931e6e
Compare
…emoving the auth/is-domain-exclusive-sso.ts logic
…est is_valid_email_address thouroughly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For an SSO with an exclusive domain configuration
["*"], take over all accounts on the platform.This is getting really complicated,because I found there is code I never saw, and which is wrong. Why does
auth/is-domain-exclusive-sso.tsapply a different logic? In any case, the file with the other logic is gone, and it just calls the same as elsewhere. The behavior is tested inutil/auth-check-required-sso.test.ts.Checklist: