support for ecl 23.9.9 #36235
support for ecl 23.9.9 #36235
Conversation
|
Documentation preview for this PR (built with commit 26f1b72; changes) is ready! 🎉 |
|
Should there by any tests in |
How would we know a future release of ecl will break compatibility? Are you suggesting that only currently known versions are allowed? That doesn't seem very useful since most new releases of most software are reasonably backwards compatible. In this case, the incompatibility was detected soon enough and this PR seems to fix it. Can you confirm that it works for you? |
|
This works for me so far. I want to try at least one more thing, though. |
|
This works with |
jhpalmieri
added
s: positive review
p: blocker / 1
and removed
s: needs review
p: critical / 2
labels
|
Blocker since it is necessary when using the latest homebrew version of |
|
Works on Gentoo too, thanks. |
ecl 23.9.9 has two minor changes that affect sagemath:
- api for bignums changed, so the macro `ecl_mpz_from_bignum` has to be
(conditionally) changed
- printing of floating point numbers changed `1.e40` to `1.0e40`, I
changed the example to `1.234e40` which prints the same in 23.9.9 as in
previous versions.
With this changes sagemath should work ok with either 21.2.1 or 23.9.9.
URL: sagemath#36235
Reported by: Gonzalo Tornaría
Reviewer(s):
ecl 23.9.9 has two minor changes that affect sagemath:
ecl_mpz_from_bignumhas to be (conditionally) changed1.e40to1.0e40, I changed the example to1.234e40which prints the same in 23.9.9 as in previous versions.With this changes sagemath should work ok with either 21.2.1 or 23.9.9.