add multiple= option to EllipticCurvePoint_field.set_order() #35935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyyyx4
force-pushed
the
public/set_order_from_multiple
branch
from
454a3fc to
0ce0a02
Compare
yyyyx4
force-pushed
the
public/set_order_from_multiple
branch
from
0ce0a02 to
3e97ff9
Compare
|
Documentation preview for this PR (built with commit 3e97ff9; changes) is ready! 🎉 |
JohnCremona
approved these changes
Aug 7, 2023
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 11, 2023
…t_order()
Calling `order_from_multiple()` followed by `.set_order()` on elliptic-
curve points is a common pattern in algorithms for elliptic curves over
finite fields (for instance, this is part of a simple algorithm for
sampling points of specified order). This patch adds a shorthand for the
combination, allowing us to write `P.set_order(multiple=m)` instead.
URL: sagemath#35935
Reported by: Lorenz Panny
Reviewer(s): John Cremona
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
order_from_multiple()followed by.set_order()on elliptic-curve points is a common pattern in algorithms for elliptic curves over finite fields (for instance, this is part of a simple algorithm for sampling points of specified order). This patch adds a shorthand for the combination, allowing us to writeP.set_order(multiple=m)instead.