Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cygwin: various heegner_index errors involving interval arithmetic on cygwin #9176

Closed
williamstein opened this issue Jun 7, 2010 · 25 comments

Comments

@williamstein
Copy link
Contributor


sage -t  "devel/sage/sage/schemes/elliptic_curves/heegner.py"
**********************************************************************
File "/home/wstein/sage-4.4.3/devel/sage/sage/schemes/elliptic_curves/heegner.py", line 6380:
    sage: E.heegner_index(-7)
Expected:
    1.00000?
Got:
    1
**********************************************************************
File "/home/wstein/sage-4.4.3/devel/sage/sage/schemes/elliptic_curves/heegner.py", line 6410:
    sage: I = E.heegner_index(-8); I
Expected:
    1.50000?
Got:
    1
**********************************************************************
File "/home/wstein/sage-4.4.3/devel/sage/sage/schemes/elliptic_curves/heegner.py", line 6412:
    sage: 2*I
Expected:
    3.0000?
Got:
    2
**********************************************************************
File "/home/wstein/sage-4.4.3/devel/sage/sage/schemes/elliptic_curves/heegner.py", line 6546:
    sage: E.heegner_index_bound()
Expected:
    ([2], -7)
Got:
    ([], -7)
**********************************************************************
2 items had failures:
   3 of  15 in __main__.example_229
   1 of   4 in __main__.example_231
***Test Failed*** 4 failures.
For whitespace errors, see the file /home/wstein/.sage//tmp/.doctest_heegner.py

CC: @kcrisman @dimpase

Component: porting: Cygwin

Reviewer: Jean-Pierre Flori, Dmitrii Pasechnik, Karl-Dieter Crisman

Issue created by migration from https://trac.sagemath.org/ticket/9176

@kcrisman
Copy link
Member

kcrisman commented Aug 2, 2011

comment:1

This file passed doctests in a build of mine on XP.

@kcrisman
Copy link
Member

comment:2

But trying the first example by hand leads to a segfault (presumably related to the segfault currently bedeveling Cygwin startup, see #11551).

That is weird. Is it possible that a silent segfault makes a doctest think it passed?

@jpflori
Copy link

jpflori commented Jan 15, 2013

comment:3

Got lots of failures, apparently because of forking issues, I'll try a rebase.

@jpflori
Copy link

jpflori commented Jan 15, 2013

comment:4

Also lots of MemoryError for PARI trying to allocate memory.

@kcrisman
Copy link
Member

comment:5

Got lots of failures, apparently because of forking issues, I'll try a rebase.

Glad at least one of the forking issues I had cropped up for you :-) Even if it does work on a rebase, don't forget to try by hand as well.

@jpflori
Copy link

jpflori commented Jan 15, 2013

comment:6

And indeed inside "./sage -gp" I cannot allocatemem(512000000), but only 256000000, not sure why though.

@jpflori
Copy link

jpflori commented Jan 15, 2013

comment:7

I think I only have one forking issue (among 202 failing tests) caused by ecl which I rebuilt in the end (and potentially did not rebase after that).

@jpflori
Copy link

jpflori commented Jan 15, 2013

comment:8

And I guess it is http://cygwin.com/cygwin-ug-net/setup-maxmem.html so was expected.

So I'm left with the one forking issue :)

@jpflori
Copy link

jpflori commented Jan 15, 2013

comment:9

Ok I still get the forking issue after rebasing :( the only solution might be to get a clean install at once (I rebuilt ECL p1 spkg and dependencies after having installed all Sage with the p0).

Not sure how to let Cygwin increase the mx mem used, using peflags on python tells me it could not open the file...

@jpflori
Copy link

jpflori commented Jan 16, 2013

comment:10

The max mem I can allocate is 502333407 and all the hacks I tried in the registry seem to have no (good or bad) effect.

@jpflori
Copy link

jpflori commented Jan 16, 2013

comment:11

Ok, I manage to use peflags to modify --cygwin-heap but if I set it to 1024MB then I get forking errors...

@jpflori
Copy link

jpflori commented Jan 16, 2013

comment:12

I can set it to 600MB without forking errors and that is enough to let the tests pass.
(And indeed the global variable heap_chunk_in_mb support has been removed in Cygwin 1.7.10, see http://cygwin.com/cygwin-ug-net/ov-new1.7.html.)

@dimpase
Copy link
Member

dimpase commented Jan 27, 2013

comment:13

I propose to close it (as won't fix/worksforme), as it works now.

@jpflori
Copy link

jpflori commented Jan 30, 2013

comment:14

Replying to @dimpase:

I propose to close it (as won't fix/worksforme), as it works now.

Did you actually manage to run the test without hacking around with --cygwin-heap?
I think we should at least add some doc somewhere to state that the tests are expected to fail with default max heap memory and how to modify that (e.g. use peflags and the global var is not supported anymore).

@jpflori
Copy link

jpflori commented Mar 1, 2013

comment:16

Anyway, I don't think we should deal with the peflags usage in another ticket as this was not the point of this ticket originally.

So lets close this one.
Ill open a ticket for documenting usage of peflags shortly.

@jpflori
Copy link

jpflori commented Mar 1, 2013

comment:17

This is #14207.

@kcrisman
Copy link
Member

kcrisman commented Mar 8, 2013

comment:18

Okay, I finally got this to doctest without forking errors, and mostly am seeing the same problem you are. I'm not going to bother messing around with Pari's memory because I don't know how to do that and you guys are on it. I do get a lot of extra failures

Expected:
    0
Got:
    32

which seems to be exactly one per example. Of course, there is no such doctest listed in the file, so this must be something in the framework.

@jpflori
Copy link

jpflori commented Mar 14, 2013

comment:19

Replying to @kcrisman:

Okay, I finally got this to doctest without forking errors, and mostly am seeing the same problem you are. I'm not going to bother messing around with Pari's memory because I don't know how to do that and you guys are on it. I do get a lot of extra failures

Expected:
    0
Got:
    32

I guess these extra failures are mostly due to the fact a previous doctest needing too much memory for PARI failed.

which seems to be exactly one per example. Of course, there is no such doctest listed in the file, so this must be something in the framework.

@kcrisman
Copy link
Member

comment:20

Sorry for not following up - so you agree with Dima that this is a pure memory issue, and so should be closed? Should we at least put a mention in the doc for this file that "if you are on a system with not much memory allocated (such as default Cygwin, but perhaps others like tablets or something) then there is this trick, see the verbiage added by #14207"?

@jpflori
Copy link

jpflori commented Mar 30, 2013

comment:21

I do, lets close this one.

@jdemeyer
Copy link

jdemeyer commented Apr 1, 2013

comment:22

Please fill in Author/Reviewer.

@jpflori
Copy link

jpflori commented Apr 1, 2013

Author: Jean-Pierre Flori, Dmitrii Pasechnick, Karl-Dieter Crisman

@jpflori jpflori removed this from the sage-5.9 milestone Apr 1, 2013
@jpflori
Copy link

jpflori commented Apr 1, 2013

Changed author from Jean-Pierre Flori, Dmitrii Pasechnick, Karl-Dieter Crisman to none

@jpflori
Copy link

jpflori commented Apr 1, 2013

Reviewer: Jean-Pierre Flori, Dmitrii Pasechnick, Karl-Dieter Crisman

@jpflori
Copy link

jpflori commented Apr 1, 2013

Changed reviewer from Jean-Pierre Flori, Dmitrii Pasechnick, Karl-Dieter Crisman to Jean-Pierre Flori, Dmitrii Pasechnik, Karl-Dieter Crisman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants