Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derangements #9005

Closed
sagetrac-amca01 mannequin opened this issue May 21, 2010 · 10 comments
Closed

Derangements #9005

sagetrac-amca01 mannequin opened this issue May 21, 2010 · 10 comments

Comments

@sagetrac-amca01
Copy link
Mannequin

sagetrac-amca01 mannequin commented May 21, 2010

The current implementation in Sage for derangements is a wrapper for the GAP "derangements" and "number_of_derangements" which is very restrictive. For example, it doesn't allow derangements of arbitrary lists or strings. The documentation observes

"Warning - Wraps GAP - hence mset must be a list of objects that have string representations that can be interpreted by the GAP interpreter. If mset consists of at all complicated Sage objects, this function does not do what you expect. A proper function should be written! (TODO!)"

This file is an attempt to provide that.

CC: @nathanncohen @ppurka

Component: combinatorics

Keywords: derangements

Author: Alasdair McAndrew, Travis Scrimshaw

Reviewer: Ben Salisbury

Merged: sage-5.10.beta1

Issue created by migration from https://trac.sagemath.org/ticket/9005

@sagetrac-amca01
Copy link
Mannequin Author

sagetrac-amca01 mannequin commented May 21, 2010

Work Issues: It does not yet pass all doctests

@sagetrac-amca01
Copy link
Mannequin Author

sagetrac-amca01 mannequin commented May 29, 2010

Attachment: derangements.sage.gz

@tscrim
Copy link
Collaborator

tscrim commented Apr 1, 2013

Changed work issues from It does not yet pass all doctests to none

@tscrim
Copy link
Collaborator

tscrim commented Apr 1, 2013

Changed author from Alasdair McAndrew to Alasdair McAndrew, Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Apr 1, 2013

Changed upstream from Not yet reported upstream; Will do shortly. to none

@tscrim
Copy link
Collaborator

tscrim commented Apr 1, 2013

comment:4

Converted the sage file into a patch and brought it up to our current standards. Ready for review.

@tscrim tscrim added this to the sage-5.9 milestone Apr 1, 2013
@tscrim tscrim removed the t: feature label Apr 1, 2013
@bsalisbury1
Copy link

Reviewer: Ben Salisbury

@jdemeyer
Copy link

comment:6

The patch is not a proper patch file, patches should be generated using hg export tip.

@tscrim
Copy link
Collaborator

tscrim commented Apr 23, 2013

comment:7

Attachment: trac_9005-derangements-ts.patch.gz

Sorry about that. Fixed.

@jdemeyer
Copy link

Merged: sage-5.10.beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants