-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook redirects use wrong HTTP Status Code (301 Moved Permanently) #8724
Comments
Attachment: trac_8724-sagenb-redirect-code.patch.gz Changes status code of redirects to 303. Also fixes a bunch of Selenium tests. Apply to sagenb repo. |
Author: Tim Dumol |
comment:2
(I'm not changing any notebook code in Sage 4.4.) |
comment:3
This looks great! |
Apply after first patch |
comment:5
Attachment: trac_8724-doctest-fix.patch.gz |
Merged: 4.4.1.alpha2 |
Reviewer: William Stein |
Changed author from Tim Dumol to Tim Dumol, Alex Leone |
Changed merged from 4.4.1.alpha2 to sage-4.4.1.alpha2 |
Notebook redirects use status code 301 to redirect to new pages, when they should use code 303 See Other. Because of this, Google Chrome caches the redirect, leading to problems with creating new worksheets, emptying trash, etc. If the redirect is cached, the requested action will not be performed, as the browser will redirect directly to the original url.
For example, if you are to click the "New Worksheet" link twice, you would expect to create two new worksheets. However, the second click redirects you directly to the first created worksheet.
Thanks to mpatel for spotting this.
CC: @qed777
Component: notebook
Author: Tim Dumol, Alex Leone
Reviewer: William Stein
Merged: sage-4.4.1.alpha2
Issue created by migration from https://trac.sagemath.org/ticket/8724
The text was updated successfully, but these errors were encountered: