Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook redirects use wrong HTTP Status Code (301 Moved Permanently) #8724

Closed
TimDumol mannequin opened this issue Apr 20, 2010 · 10 comments
Closed

Notebook redirects use wrong HTTP Status Code (301 Moved Permanently) #8724

TimDumol mannequin opened this issue Apr 20, 2010 · 10 comments

Comments

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Apr 20, 2010

Notebook redirects use status code 301 to redirect to new pages, when they should use code 303 See Other. Because of this, Google Chrome caches the redirect, leading to problems with creating new worksheets, emptying trash, etc. If the redirect is cached, the requested action will not be performed, as the browser will redirect directly to the original url.

For example, if you are to click the "New Worksheet" link twice, you would expect to create two new worksheets. However, the second click redirects you directly to the first created worksheet.

Thanks to mpatel for spotting this.

CC: @qed777

Component: notebook

Author: Tim Dumol, Alex Leone

Reviewer: William Stein

Merged: sage-4.4.1.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/8724

@TimDumol TimDumol mannequin added this to the sage-4.4 milestone Apr 20, 2010
@TimDumol TimDumol mannequin assigned jasongrout and williamstein Apr 20, 2010
@TimDumol
Copy link
Mannequin Author

TimDumol mannequin commented Apr 20, 2010

Attachment: trac_8724-sagenb-redirect-code.patch.gz

Changes status code of redirects to 303. Also fixes a bunch of Selenium tests. Apply to sagenb repo.

@TimDumol
Copy link
Mannequin Author

TimDumol mannequin commented Apr 20, 2010

Author: Tim Dumol

@TimDumol TimDumol mannequin added the s: needs review label Apr 20, 2010
@jhpalmieri
Copy link
Member

comment:2

(I'm not changing any notebook code in Sage 4.4.)

@jhpalmieri jhpalmieri modified the milestones: sage-4.4, sage-5.0 Apr 23, 2010
@williamstein
Copy link
Contributor

comment:3

This looks great!

@sagetrac-acleone
Copy link
Mannequin

sagetrac-acleone mannequin commented Apr 24, 2010

Apply after first patch

@jhpalmieri
Copy link
Member

comment:5

Attachment: trac_8724-doctest-fix.patch.gz

@jhpalmieri jhpalmieri modified the milestones: sage-5.0, sage-4.4.1 Apr 27, 2010
@williamstein
Copy link
Contributor

Merged: 4.4.1.alpha2

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Apr 29, 2010

Reviewer: William Stein

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Apr 29, 2010

Changed author from Tim Dumol to Tim Dumol, Alex Leone

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented May 3, 2010

Changed merged from 4.4.1.alpha2 to sage-4.4.1.alpha2

@TimDumol TimDumol mannequin mentioned this issue May 3, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants