from __future__ import <anything> results in a Syntax Error

[TimDumol]

from future import * statements must be the first statements in a file. However, the old Sage Notebook inserts synchronization code before the file, and the new SageNB inserts prompt changing code first. Both of the aforementioned changes break the code.

CC: @qed777 @williamstein

Component: notebook

Author: Tim Dumol

Reviewer: Alex Leone

Merged: sagenb-0.7

Issue created by migration from https://trac.sagemath.org/ticket/7207

[TimDumol]

Fixed formatting to relocate future imports to the top of the file.

[TimDumol]

Author: Tim Dumol

[TimDumol]

comment:1

Attachment: trac_7207-sagenb-future-import.patch.gz

[TimDumol]

comment:2

Would anyone mind reviewing this? It just moves the displayhook_hack to another file, and adds some tests and a tad of refactoring.

[williamstein]

comment:3

Needs work, since this has a subtle bug, which I bet you can easily fix. See below.

Using regular expressions is unfortunately not rock solid. For example, this input "mysteriously" gives a SyntaxError:

print """
from __future__ import division"""

outputs:

Syntax Error:
    from __future__ import division"""

whereas the similar

print """
from __xfuture__ import division"""

works fine.

I think the right fix is to require that the even in the notebook the from `future` import ... lines appear at the very top. This would make it possible to use the same method you already used.

[TimDumol]

Uses stdlib's ast to parse the file instead of regexp's.

[TimDumol]

comment:4

Attachment: trac_7207-sagenb-future-import.2.patch.gz

This version of the patch uses ast (from stdlib). It should prevent errors such as what you described.

[TimDumol]

Attachment: trac_7207-sagenb-future-import.2.2.patch.gz

Rebased on #7650 and its dependencies.

[TimDumol]

Attachment: trac_7207-sagenb-future-import.2.3.patch.gz

Missed an import on the rebase.

[sagetrac-acleone]

Attachment: trac_7207-sagenb-future-import.3.patch.gz

Rebased to ~0.60

[sagetrac-acleone]

comment:5

Rebased to a bit after 0.60 (see trac_7207-sagenb-future-import.3.patch). Other than that LGTM.

[sagetrac-acleone]

Reviewer: Alex Leone

[qed777]

comment:6

V4 is rebased for this queue:

sagenb-0.6
trac_7249-jinja2_v9.5.patch
trac_7962-link-worksheets-zip-file.patch
trac_7969-escaped-backslash.patch
trac_4217-html-system-formatting.3.patch
trac_3083-print-documentation.5.patch
trac_6182-double-quotes-ws.2.patch
trac_5263-publish-url.patch
trac_7631-republish-name.patch
trac_6353-cookies-diff-ports.patch
trac_7207-sagenb-future-import.3.patch

[qed777]

Rebased for SageNB 0.6 + queue in comment. Replaces previous.

[qed777]

Merged: sagenb-0.7

[qed777]

comment:7

Attachment: trac_7207-sagenb-future-import.4.patch.gz