-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[with spkg and patch] Update to Maxima 5.19.1 (particularly important for Solaris support). #6699
Comments
Author: David Kirkby |
comment:3
Starting from sage 4.1.1, I installed ecl-9.8.3.spkg and maxima-5.19.0.spkg. The following errors occurred.
It appears that the output from maxima has changed in a number of cases and is returning more comments and the like. I don't know if this is the correct/new behaviour of maxima. Adam |
comment:4
So it seems that a number of doctests need to be fixed. I'm marking this as "needs work", although the spkg itself seems fine, we just need a patch that fixes the doctests. Note that interfaces/maxima.py is most likely not the only file affected by this. |
comment:5
After creating this ticket, a newer Maxima was released. The spkg can be found here http://sage.math.washington.edu/home/kirkby/Solaris-fixes/maxima-5.19.1/ |
comment:6
I'm attaching a patch that fixes all but one of the doctest failures observed on sage.math and other Linux machines. Most of these are very simple fixes due to (a) change of formatting of Maxima output or (b) new functionality in Maxima. For anything else I have tried to comment on my fix in the corresponding file. Where new answers appear due to new functionality, I checked these answers against Wolfram Alpha (yes, I know; I feel weird about this). As far as I know there is one remaining doctest failures:
I think this is due to the fact that Maxima now only returns the real solution, and ignores the complex solution. I'm not sure what we should do about this. Note that there are also some timeouts observed by David Kirkby on Solaris, but at least some of them are not Maxima-related so it would be better to deal with them in separate tickets. Finally, this patch puts together a number of tiny patches on a number of recently-opened tickets. I've decided that it is quite a bit easier to just referee the whole thing, and definitely easier for me to maintain and make necessary modifications to a single patch rather than a dozen of them. |
Changed keywords from none to maxima |
apply after the ecl and maxima spkg's |
comment:7
Attachment: maxima_doctests.patch.gz Replying to @aghitza: sage -t "expression.pyx" File "/opt/sage-4.1.1/devel/sage-main/sage/symbolic/expression.pyx", line 5541: }}}
I think you are right. Maxima treats variables to be real by default. To see that in maxima
So, if maxima is throwing away complex solution then its consistent with its own assumptions. |
comment:8
Actually, I was wrong. This is a bug in Maxima, which used to give the right answer but doesn't any more. See http://www.math.utexas.edu/pipermail/maxima/2009/017632.html for a discussion of this. |
comment:9
We might have to get Maxima's "solutions" and check them before returning them to the user. This is a pain. |
Changed author from David Kirkby to David Kirkby, Alex Ghitza |
comment:10
OK, I have come up with a workaround for Maxima's bug. Since we are now patching Maxima 5.19.1, I've made a new spkg with "bumped" version number: http://sage.math.washington.edu/home/ghitza/maxima-5.19.1.p0.spkg I will soon explain my workaround here to facilitate reviewing, but I thought I'd first put the spkg up in case people want to test it. |
comment:11
Here's a description of the problem and the workaround patched in the latest spkg: We are calling Maxima's function Maxima 5.16.3:
Maxima 5.19.1:
The main difference between the two is that The right way to fix this is to properly debug For now, I'm patching |
Reviewer: Adam Webb |
comment:13
Not to be pedantic but it would be good to add the usual stuff to the SPKG.txt file to make it more like other packages. I don't know if anyone would like to put their name in for the package maintainer.
The patch seems quite reasonable to me. Most of it seems to be due to improvements in maxima. Changing parg back to carg will likely have to be looked at in a future update but I think is appropriate at this time. I tested the package on 32 and 64 bit linux and it worked well. I ran 'make testlong' and everything passed. I give it a positive review. Has this been tested on Solaris? Adam |
comment:14
Adam, Thanks for taking the time to review this. I have made changes very close to what you suggested in SPKG.txt, and replaced the spkg -- it's in the same place as before. I also changed the ticket summary in light of your positive review. |
comment:15
Merged |
Changed reviewer from Adam Webb to Adam Webb, Minh Van Nguyen |
Merged: Sage 4.1.2.alpha0 |
comment:16
See #6883 for a follow-up to this ticket. |
I've made a new .spkg file for Maxima based on the latest 5.19.0 release.
http://sage.math.washington.edu/home/kirkby/Solaris-fixes/maxima-5.19.0/maxima-5.19.0.spkg
I gather updates to Maxima have caused some issues in the past in Sage, so I don't know how this will go.
I've also created a new .spkg file for ECL, based on the latest 9.8.1 source code (despite the fact the web site shows 9.7.1 as the latest, if you go to the downloads page, you can get 9.8.1).
http://sage.math.washington.edu/home/kirkby/Solaris-fixes/ecl-9.8.1/ecl-9.8.1.spkg
This updated ECL resolves Trac #6564, as ECL 9.8.1 works on Solaris SPARC, but ECL 9.7.1 does not.
If the updated ECL is applied (so solving #6564), Maxima must be updated, as improved type-check in ECL has found a bug that existed in Maxima for 35 years! (confirmed by Maxima developers).
So in summary
This suggests to me that if there are issues in Sage with this latest Maxima, they should be resolved. There is no point staying with an old version of Maxima, which needs an old version of ECL, which will not build on Solaris.
I appreciate things might not be as simple as that.
Dave
Component: packages: standard
Keywords: maxima
Author: David Kirkby, Alex Ghitza
Reviewer: Adam Webb, Minh Van Nguyen
Merged: Sage 4.1.2.alpha0
Issue created by migration from https://trac.sagemath.org/ticket/6699
The text was updated successfully, but these errors were encountered: