Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdist makes sage unable to run without building #6411

Closed
rlmill mannequin opened this issue Jun 25, 2009 · 7 comments
Closed

sdist makes sage unable to run without building #6411

rlmill mannequin opened this issue Jun 25, 2009 · 7 comments
Assignees
@craigcitro
Labels
c: distribution p: major / 3 t: bug
Milestone
sage-4.3.1

Comments

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jun 25, 2009

William was complaining about being unable to reproduce this, so here's an easy way to reproduce it:

Take sage-4.1.alpha1, do an sdist, and try running sage. Boom.

CC: @williamstein

Component: distribution

Author: Mike Hansen

Reviewer: Willem Jan Palenstijn

Merged: sage-4.3.1.rc1

Issue created by migration from https://trac.sagemath.org/ticket/6411
@rlmill rlmill mannequin added this to the sage-4.3.1 milestone Jun 25, 2009
@rlmill rlmill mannequin added c: distribution labels Jun 25, 2009
@rlmill rlmill mannequin assigned craigcitro Jun 25, 2009
@mwhansen
Copy link
Contributor

comment:1

I think if you run a "sage -br" afterward, it will work. There are just a few things that get compiled when doing that. Looking at those, it should be easy to trac down what changed.

@mwhansen
Copy link
Contributor

comment:2

This is because in spkg-dist, we do the following:

rm -rf c_lib/*.so c_lib/*.os c_lib/*/*.os c_lib/*/*/*.os

This causes libcsage to be built again. What we should do instead is delete the files from the tmp directory that we copy things into.

@mwhansen
Copy link
Contributor

Author: Mike Hansen

@mwhansen
Copy link
Contributor

Attachment: trac_6411.patch.gz

@wjp
Copy link
Mannequin

wjp mannequin commented Jan 17, 2010

comment:4

This looks good, and fixes the problem for me.

@wjp wjp mannequin added s: positive review and removed s: needs review labels Jan 17, 2010
@rlmill
Copy link
Mannequin Author

rlmill mannequin commented Jan 18, 2010

Reviewer: Willem Jan Palenstijn

@rlmill
Copy link
Mannequin Author

rlmill mannequin commented Jan 18, 2010

Merged: sage-4.3.1.rc1

@rlmill rlmill mannequin removed the s: positive review label Jan 18, 2010
@rlmill rlmill mannequin closed this as completed Jan 18, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@craigcitro craigcitro

Labels
c: distribution p: major / 3 t: bug
Projects
None yet
Milestone
sage-4.3.1
Development

No branches or pull requests
2 participants
@mwhansen @craigcitro