Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook -- Saving a worksheet with double quotes in the worksheet name fails with a weird error #6182

Closed
williamstein opened this issue Jun 2, 2009 · 12 comments
Closed

Notebook -- Saving a worksheet with double quotes in the worksheet name fails with a weird error #6182

williamstein opened this issue Jun 2, 2009 · 12 comments
Assignees
@boothby
Labels
c: user interface p: major / 3 t: bug
Milestone
sage-4.3.2

Comments

@williamstein
Copy link
Contributor

Javascript errors show up in console which pretty much messes up all javascript in the page (S-Enter, etc.).

CC: @williamstein @mwhansen @qed777

Component: notebook

Author: Tim Dumol

Reviewer: Mitesh Patel

Merged: sagenb-0.7

Issue created by migration from https://trac.sagemath.org/ticket/6182
@williamstein williamstein added this to the sage-4.3.2 milestone Jun 2, 2009
@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 18, 2010

comment:1

This works now. Confirm and close?

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 18, 2010

Work Issues: Close/mark as fixed?

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 18, 2010

Escapes worksheet names passed to javascript

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 18, 2010

comment:2

Attachment: trac_6182-double-quotes-ws.patch.gz

I take that back. It doesn't fail immediately, but it does fail.

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 18, 2010

Changed work issues from Close/mark as fixed? to none

@TimDumol

This comment has been minimized.

Sign in to view
@TimDumol TimDumol mannequin changed the title notebook -- saving a worksheet with double quotes in the worksheet name fails with a weird error Notebook -- Saving a worksheet with double quotes in the worksheet name fails with a weird error Jan 18, 2010
@TimDumol TimDumol mannequin added the s: needs review label Jan 18, 2010
@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 18, 2010

comment:3

This should depend on #7650, #7294 and #7786 and their dependencies. Possibly some others.

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 20, 2010

comment:4

V2 is rebased to drop changes to template.py (earlier patch).

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 20, 2010

Reviewer: Mitesh Patel

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 20, 2010

Author: Tim Dumol

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 20, 2010

Attachment: trac_6182-double-quotes-ws.2.patch.gz

Rebased version without changes to template.py. Replaces previous.

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 25, 2010

Merged: sagenb-0.7

@qed777 qed777 mannequin removed the s: positive review label Jan 25, 2010
@qed777 qed777 mannequin closed this as completed Jan 25, 2010
@qed777 qed777 mannequin mentioned this issue Feb 10, 2010
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boothby boothby

Labels
c: user interface p: major / 3 t: bug
Projects
None yet
Milestone
sage-4.3.2
Development

No branches or pull requests
2 participants
@boothby @williamstein