-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plural wrapper #4539
Comments
initial wrapper for plural |
Attachment: plural_1.patch.gz better user interface for plural rings |
Attachment: plural_2.patch.gz |
comment:1
Attachment: letterplace.py.gz |
comment:3
The letterplace interface in attachment: letterplace.py is now at #7797. |
Attachment: plural_1.sage-4.4.4.patch.gz rebased to 4.4.4 |
rebased to 4.4.4 |
Attachment: plural_2.sage-4.4.4.patch.gz Attachment: plural_3.patch.gz appy on top of 1 and 2, new classes for plural objects which don't inherit from the commutative ones |
Attachment: plural_functions.2.patch.gz |
comment:4
sorry, for multiple files. Apply patches in this order: plural_1.sage-4.4.4.patch plural_2.sage-4.4.4.patch plural_3.patch Download plural_functions.patch |
comment:5
Attachment: plural_functions.patch.gz |
i have just folded all the previous patches by Michael & Burcin into plural_folded-4.4.4.patch (should be applied before anything else) |
Attachment: plural_folded-4.4.4.patch.gz Part one Olekandr's work in Linz |
Attachment: extending_plural_folded-4.4.4.patch.gz Attachment: extplural-more.gz Doctest fixes by Alexander |
Attachment: extplural-more.patch.gz Doctest fixes by Alexander |
Attachment: extplural-more2.patch.gz noncommunative ring functionality |
Attachment: extplural-more3.patch.gz |
Attachment: plural-wrapper-2010-07-22.patch.gz This folds of the following patches, a crucial subset of the noncommutation fucntionality as well as extensive documentation and doctests |
comment:7
We have an first release ready for reviewing! Regards, Oleksandr and Alexander |
comment:117
Attachment: trac4539_docbuild_reviewer.patch.gz Hi Alexander, Note that there is a new patch at #10903 (where the docbuild crash was introduced), and it fixes the problem in a more satisfying way. The problem was that under certain circumstances the name of a deprecated Cython method could not be determined - but with the new patch from #10903 (actually there are TWO new patches) the problem is fixed. So, the docbuild reviewer patch is not needed. |
comment:118
Building, installing and testing succeeded on SuSE 11 Enterprise amd64 and OS X 10.5 ppc. So we can switch back to positive review. |
comment:121
Attachment: trac4539_libplural_rel11761.patch.gz |
This comment has been minimized.
This comment has been minimized.
comment:122
It could be that we need some work here. The first patch does not apply when we start with sage-4.8.alpha0. Namely, in sage/libs/singular/function.pyx, it expects the line
but this line has been removed. I don't know in which ticket that has happened. By consequence, a rather complicated chunk of the patch does not apply. What shall we do? In order to avoid premature work, it would be an option to wait until finally all the dependencies got a positive review. |
comment:123
That line comes from https://github.com/sagemath/sage-prod/files/10653584/11761-cython-0.15.patch.gz (Cython is more strict here.) That patch was not merged in alpha0. |
comment:124
Replying to @alexanderdreyer:
Yes, now I see it: #11761 is a dependency! So, sorry for the noise, and back to a positive review - which needs two steps. One... |
comment:125
... and two. |
Merged: sage-5.0.beta1 |
During SD10 in Nancy, Michael Brickenstein and Burcin Erocal worked on making Plural (the non-commutative extension of Singular) accessible from Sage. Burcin and Michael also worked at the Plural wrapper on SD 23.5 in Kaiserslautern. Oleksandr Motsak and Alexander Dreyer continued this at SD 24 in Linz.
The patches that resulted from this work are attached.
Newest functionality:
Possible topics that need work are:
Apply
Depends on #11316
Depends on #11856
Depends on #10903
Depends on #9138
Depends on #11900
Depends on #11115
Depends on #11068
Depends on #11761
CC: @saliola @mwhansen @alexanderdreyer @sagetrac-OleksandrMotsak @sagetrac-PolyBoRi @malb @simon-king-jena
Component: algebra
Keywords: libsingular plural wrapper sd10 sd23.5 sd24 sd34
Author: Michael Brickenstein, Burcin Erocal, Oleksandr Motsak, Alexander Dreyer, Simon King
Reviewer: Simon King, Alexander Dreyer
Merged: sage-5.0.beta1
Issue created by migration from https://trac.sagemath.org/ticket/4539
The text was updated successfully, but these errors were encountered: