Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VectorFieldModule: Faster fast path for tensor_module, exterior_power, dual_exterior_power #34486

Closed
mkoeppe opened this issue Sep 3, 2022 · 7 comments
Closed

VectorFieldModule: Faster fast path for tensor_module, exterior_power, dual_exterior_power #34486

mkoeppe opened this issue Sep 3, 2022 · 7 comments
Labels
c: manifolds p: minor / 4 t: enhancement
Milestone
sage-9.8

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 3, 2022

using try...except, as previously done for these methods in TensorFreeModule, VectorFieldFreeModule

CC: @egourgoulhon

Component: manifolds

Author: Matthias Koeppe

Branch/Commit: 0d2539a

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/34486
@mkoeppe mkoeppe added this to the sage-9.8 milestone Sep 3, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 3, 2022

Branch: u/mkoeppe/vectorfieldmodule__faster_fast_path_for_tensor_module__exterior_power__dual_exterior_power

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 3, 2022

New commits:

0d2539aVectorFieldModule: Faster fast path for tensor_module, exterior_power, dual_exterior_power

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 3, 2022

Commit: 0d2539a

@egourgoulhon
Copy link
Member

comment:3

LGTM. Thanks.

@egourgoulhon
Copy link
Member

Reviewer: Eric Gourgoulhon

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 5, 2022

comment:4

Thank you!

@vbraun
Copy link
Member

vbraun commented Sep 27, 2022

Changed branch from u/mkoeppe/vectorfieldmodule__faster_fast_path_for_tensor_module__exterior_power__dual_exterior_power to 0d2539a

@vbraun vbraun closed this as completed in c036ccc Sep 27, 2022
@egourgoulhon egourgoulhon mentioned this issue Jan 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: manifolds p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @egourgoulhon @mkoeppe