Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multimajor index for permutations #34373

Closed
25shriya opened this issue Aug 16, 2022 · 25 comments
Closed

Implement multimajor index for permutations #34373

25shriya opened this issue Aug 16, 2022 · 25 comments

Comments

@25shriya
Copy link
Contributor

We add an implementation for the multimajor index
of a permutation with respect to a combination of
the same size, as described in:

Armin Jöllenbeck and Manfred Schocker. Cyclic
characters of symmetric groups. J. Algebraic Combin.,
12 (2000), 155-161. doi:10.1023/A:1026592027019

Component: combinatorics

Keywords: permutations, major index, days114/club

Author: Amrutha P, Shriya M, Divya Aggarwal, Aritra Bhattacharya

Branch/Commit: 9a93d1d

Reviewer: Amrutha P, Aritra Bhattacharya, Julian Rüth, Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/34373

@25shriya 25shriya added this to the sage-9.7 milestone Aug 16, 2022
@25shriya
Copy link
Contributor Author

Branch: u/gh-25shriya/34373

@25shriya
Copy link
Contributor Author

New commits:

2cb5411Add multimajor index

@25shriya
Copy link
Contributor Author

Changed author from Amrutha P to Amrutha P, Shriya M, Divya Aggarwal

@25shriya
Copy link
Contributor Author

Commit: 2cb5411

@aggarwaldivya
Copy link
Mannequin

aggarwaldivya mannequin commented Aug 17, 2022

Changed keywords from partitions, major index to permutations, major index

@aggarwaldivya aggarwaldivya mannequin changed the title Implement Multimajor index for partitions Implement Multimajor index for permutations Aug 17, 2022
@fchapoton
Copy link
Contributor

comment:3
File "sage/combinat/permutation.py", line 3384, in sage.combinat.permutation.Permutation.multi_major_index
Failed example:
    Permutation([5, 6, 2, 1, 3, 7, 4]).multi_major_index(Composition([3, 2, 2]))
Exception raised:
    Traceback (most recent call last):
      File "/__w/sagetrac-mirror/sagetrac-mirror/src/sage/doctest/forker.py", line 695, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/__w/sagetrac-mirror/sagetrac-mirror/src/sage/doctest/forker.py", line 1093, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.combinat.permutation.Permutation.multi_major_index[0]>", line 1, in <module>
        Permutation([Integer(5), Integer(6), Integer(2), Integer(1), Integer(3), Integer(7), Integer(4)]).multi_major_index(Composition([Integer(3), Integer(2), Integer(2)]))
      File "/__w/sagetrac-mirror/sagetrac-mirror/src/sage/combinat/permutation.py", line 3394, in multi_major_index
        for i, qi in enumerate(q):
    NameError: name 'q' is not defined

@fchapoton
Copy link
Contributor

comment:4

also please write the full real names in the "Authors" field here above.

@slel
Copy link
Member

slel commented Aug 19, 2022

Changed keywords from permutations, major index to permutations, major index, days114/club

@slel
Copy link
Member

slel commented Aug 19, 2022

comment:5

This ticket is being worked on as part of the
Chennai Sage Club.

Reviewer commits are coming up next week.

Regarding names, these are the full names. (I had the same doubt and asked).


Further reading on names:

In particular, that last page hints single letter names exist,
and are not always initials.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 23, 2022

Changed commit from 2cb5411 to 5e55c77

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 23, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

5e55c77Speed up multimajor index

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 23, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

53cc12dAdd examples for multimajor index

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 23, 2022

Changed commit from 5e55c77 to 53cc12d

@aritra-bhattacharya-0
Copy link
Contributor

Changed branch from u/gh-25shriya/34373 to public/34373

@aritra-bhattacharya-0
Copy link
Contributor

Changed commit from 53cc12d to 1a468ca

@aritra-bhattacharya-0
Copy link
Contributor

Changed author from Amrutha P, Shriya M, Divya Aggarwal to Amrutha P, Shriya M, Divya Aggarwal, Aritra Bhattacharya

@aritra-bhattacharya-0
Copy link
Contributor

New commits:

1a468caImprove wording

@fchapoton
Copy link
Contributor

comment:10

the meaning of :meth:`size` in the INPUT is not clear

the raise ValueError code line should be tested by a doctest inside TESTS::

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2022

Changed commit from 1a468ca to 9a93d1d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

9a93d1dAdd doctest for multimajor index

@saraedum
Copy link
Member

Reviewer: Amrutha P, Aritra Bhattacharya, Julian Rüth, Samuel Lelièvre

@saraedum

This comment has been minimized.

@slel

This comment has been minimized.

@slel slel changed the title Implement Multimajor index for permutations Implement multimajor index for permutations Aug 24, 2022
@slel

This comment has been minimized.

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from public/34373 to 9a93d1d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants