Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples to Schubert polynomials documentation #34370

Closed
trevorkarn opened this issue Aug 15, 2022 · 11 comments
Closed

Add examples to Schubert polynomials documentation #34370

trevorkarn opened this issue Aug 15, 2022 · 11 comments

Comments

@trevorkarn
Copy link
Contributor

Add examples to the documentation for Schubert polynomials.

CC: @tscrim @darijgr

Component: documentation

Keywords: gsoc2022 schubert-polynomial documentation

Author: Trevor K. Karn

Branch/Commit: 8fbcc34

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34370

@trevorkarn
Copy link
Contributor Author

New commits:

c2adceaAdd examples to SchubertPolynomials

@trevorkarn
Copy link
Contributor Author

Commit: c2adcea

@trevorkarn
Copy link
Contributor Author

Branch: u/tkarn/schubert-34370

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 15, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

5861650Fix typo

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 15, 2022

Changed commit from c2adcea to 5861650

@tscrim
Copy link
Collaborator

tscrim commented Aug 15, 2022

comment:3

Please get out of the habit of writing lines like this:

+In Sage, they are modeled in the :class:`SchubertPolynomial_class`. Instances of
+this class can be created by creating an instance ``X`` of a Schubert polynomial
+ring using the constructor :func:`SchubertPolynomialRing`. 

They are useless as you have the examples and are already at the code (and technical regarding implementation details).

\\Bold{Z} -> \ZZ (only one \ as the string block is marked r).

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 17, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

8fbcc34Fix reviewer comments

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 17, 2022

Changed commit from 5861650 to 8fbcc34

@tscrim
Copy link
Collaborator

tscrim commented Aug 26, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Aug 26, 2022

comment:5

Thanks. LGTM.

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from u/tkarn/schubert-34370 to 8fbcc34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants