bug in LaurentPolynomial_univariate.quo_rem

[mantepse]

We currently doctest

def quo_rem(self, right_r):
...
            sage: (t^-2 + 3 + t).quo_rem(t^-4 + t)
            (0, 1 + 3*t^2 + t^3)

I think we want

sage: q, r = num.quo_rem(den)
sage: num == den * q + r
True

Component: algebra

Author: Martin Rubey

Branch/Commit: 8798139

Reviewer: Dave Morris, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34330

[mantepse]

Branch: u/mantepse/bug_in_laurentpolynomial_univariate_quo_rem

[mantepse]

New commits:

80e3478

fix offset of remainder

[mantepse]

Commit: 80e3478

[fchapoton]

comment:3

missing space here ``q``and

[sagetrac-git]

Changed commit from 80e3478 to e4479ed

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e4479ed

fix missing space

[trevorkarn]

comment:5

Should other be right_r? Other than that it looks good to me.

[DaveWitteMorris]

comment:6

Please make an additional minor corrections to the docstring (in addition to comment:5):

• "Attempts to divide self by right and returns" should be "Attempt to divide self by right_r and return" or, more simply (and I think better), "Divide self by right_r and return".

Related ticket: #31257, which fixed a similar bug in the multivariate case. We briefly discussed the single-variable case there and I thought it was ok, but I was being stupid.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

3da6b3d

better docstring

[sagetrac-git]

Changed commit from e4479ed to 3da6b3d

[tscrim]

Changed branch from u/mantepse/bug_in_laurentpolynomial_univariate_quo_rem to public/rings/laurent_quo_rem_bug-34330

[tscrim]

Reviewer: David Morris, Travis Scrimshaw

[tscrim]

Changed commit from 3da6b3d to 8798139

[tscrim]

comment:8

I made a few other small tweaks to the doctests to make it easier for me to read and added a slightly more non-trivial test.

---

New commits:

8798139

Adding a slightly more complicated doctest and other small tweaks.

[DaveWitteMorris]

comment:9

LGTM.

[DaveWitteMorris]

Changed reviewer from David Morris, Travis Scrimshaw to Dave Morris, Travis Scrimshaw

[vbraun]

Changed branch from public/rings/laurent_quo_rem_bug-34330 to 8798139