Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker build #34242

Closed
saraedum opened this issue Jul 29, 2022 · 21 comments
Closed

Update docker build #34242

saraedum opened this issue Jul 29, 2022 · 21 comments

Comments

@saraedum
Copy link
Member

The docker images are using Ubuntu impish. We should instead build against the latest LTS version jammy.

Also, the README on Docker Hub is quite outdated.

Finally, we drop the CircleCI setup here. To my knowledge nobody is using it and I it's likely broken by now anyway.

Depends on #34360

CC: @videlec @Kerl13

Component: docker

Author: Julian Rüth

Branch: f1f5a0f

Reviewer: MartinPepin

Issue created by migration from https://trac.sagemath.org/ticket/34242

@saraedum saraedum added this to the sage-9.7 milestone Jul 29, 2022
@saraedum
Copy link
Member Author

Branch: u/saraedum/34242

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 29, 2022

Commit: c67ea14

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 29, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

0d39387Fix grammar
683f2e4Link to trac ticket correctly in README
c67ea14Let volunteers know that they are welcome to help with docker

@saraedum
Copy link
Member Author

comment:3

This needs review, once I checked that this actually works with the 9.6 build.

@RefurioAnachro
Copy link

comment:5

I just checked with 9.6, it works without ARTIFACT_BASE.

When I do set ARTIFACT_BASE=sagemath/sagemath-dev:develop then docker build errors out with

ImportError: libssl.so.1.1: cannot open shared object file: No such file or directory

which is to be expected, since ubuntu jammy switches to openssl 3.

This is a critical change: without it, building with docker fails.

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 14, 2022

Dependencies: #34360

@saraedum
Copy link
Member Author

comment:8

mkoeppe, why the "needs work"?

@saraedum
Copy link
Member Author

comment:9

Replying to @RefurioAnachro:

I just checked with 9.6, it works without ARTIFACT_BASE.

When I do set ARTIFACT_BASE=sagemath/sagemath-dev:develop then docker build errors out with

ImportError: libssl.so.1.1: cannot open shared object file: No such file or directory

which is to be expected, since ubuntu jammy switches to openssl 3.

This is a critical change: without it, building with docker fails.

I guess that's only a temporary issue. Once a newer image has been uploaded that shouldn't be an issue anymore.

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 15, 2022

comment:10

Replying to @saraedum:

I guess that's only a temporary issue. [...]

I'd suggest that you build the images and make them available for testing. Maybe then reviewers will step up.

@saraedum
Copy link
Member Author

comment:11

Yes, but unfortunately, the build failed.

@Kerl13
Copy link

Kerl13 commented Sep 10, 2022

comment:13

Replying to Julian Rueth:

Yes, but unfortunately, the build failed.

It seems to have failed for a weird reason not related to the docker configuration (apt-get not being able to install some packages).
I think it has been fixed on the develop branch, maybe merging/rebasing will be enough to fix the build ?

BTW: I also managed to build the docker images on my system using your updated dockerfile so +1 for merging this patch

@Kerl13
Copy link

Kerl13 commented Sep 17, 2022

comment:15

Replying to Julian Rüth:

Yes, but unfortunately, the build failed.

I took the liberty to rebase on develop to check whether this fixes the CI issue, and updated the ticket. Feel free to re-enable your branch at any time!


New commits:

debca31Update docker build
417ca31Fix grammar
27910f1Link to trac ticket correctly in README
f1f5a0fLet volunteers know that they are welcome to help with docker

@Kerl13
Copy link

Kerl13 commented Sep 17, 2022

Changed branch from u/saraedum/34242 to u/MartinPepin/34242

@Kerl13
Copy link

Kerl13 commented Sep 17, 2022

Changed commit from c67ea14 to f1f5a0f

@Kerl13
Copy link

Kerl13 commented Sep 20, 2022

Reviewer: MartinPepin

@Kerl13
Copy link

Kerl13 commented Sep 21, 2022

comment:19

Looks good to me, I had no problem building and using the images

@Kerl13
Copy link

Kerl13 commented Sep 21, 2022

comment:20

For anyone willing to test the images, I put them here (very temporarily):

@j2kun
Copy link

j2kun commented Sep 21, 2022

comment:21

What a timely update! I just ran into this problem when trying to derive a container from sagemath:9.5 with an additional git clone to fetch a dependency (installing git fails due to apt, and git is not installed by default on this container).

I fetched the sagemath container in comment20, and it works great. Looking forward to the push of the updated image.

@vbraun
Copy link
Member

vbraun commented Sep 25, 2022

Changed branch from u/MartinPepin/34242 to f1f5a0f

@saraedum
Copy link
Member Author

comment:23

The images on DockerHub are now also updated.

@saraedum
Copy link
Member Author

Changed commit from f1f5a0f to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants