-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker build #34242
Comments
Branch: u/saraedum/34242 |
Commit: |
comment:3
This needs review, once I checked that this actually works with the 9.6 build. |
comment:5
I just checked with 9.6, it works without ARTIFACT_BASE. When I do set ARTIFACT_BASE=sagemath/sagemath-dev:develop then docker build errors out with
which is to be expected, since ubuntu jammy switches to openssl 3. This is a critical change: without it, building with docker fails. |
Dependencies: #34360 |
comment:8
mkoeppe, why the "needs work"? |
comment:9
Replying to @RefurioAnachro:
I guess that's only a temporary issue. Once a newer image has been uploaded that shouldn't be an issue anymore. |
comment:10
Replying to @saraedum:
I'd suggest that you build the images and make them available for testing. Maybe then reviewers will step up. |
comment:11
Yes, but unfortunately, the build failed. |
comment:13
Replying to Julian Rueth:
It seems to have failed for a weird reason not related to the docker configuration ( BTW: I also managed to build the docker images on my system using your updated dockerfile so +1 for merging this patch |
comment:15
Replying to Julian Rüth:
I took the liberty to rebase on develop to check whether this fixes the CI issue, and updated the ticket. Feel free to re-enable your branch at any time! New commits:
|
Changed branch from u/saraedum/34242 to u/MartinPepin/34242 |
Reviewer: MartinPepin |
comment:19
Looks good to me, I had no problem building and using the images |
comment:20
For anyone willing to test the images, I put them here (very temporarily):
|
comment:21
What a timely update! I just ran into this problem when trying to derive a container from sagemath:9.5 with an additional git clone to fetch a dependency (installing git fails due to apt, and git is not installed by default on this container). I fetched the sagemath container in comment20, and it works great. Looking forward to the push of the updated image. |
Changed branch from u/MartinPepin/34242 to |
comment:23
The images on DockerHub are now also updated. |
Changed commit from |
The docker images are using Ubuntu impish. We should instead build against the latest LTS version jammy.
Also, the README on Docker Hub is quite outdated.
Finally, we drop the CircleCI setup here. To my knowledge nobody is using it and I it's likely broken by now anyway.
Depends on #34360
CC: @videlec @Kerl13
Component: docker
Author: Julian Rüth
Branch:
f1f5a0f
Reviewer: MartinPepin
Issue created by migration from https://trac.sagemath.org/ticket/34242
The text was updated successfully, but these errors were encountered: