Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use abstract_method for Polyhedra #33679

Closed
kliem opened this issue Apr 11, 2022 · 5 comments
Closed

Use abstract_method for Polyhedra #33679

kliem opened this issue Apr 11, 2022 · 5 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-9.7

Comments

@kliem
Copy link
Contributor

kliem commented Apr 11, 2022

This is simpler and has the advantage that the TestSuite checks that objects do not have a (non-optional) not implemented abstract method.

CC: @mkoeppe

Component: geometry

Author: Jonathan Kliem

Branch/Commit: 5d0cbf8

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33679
@kliem kliem added this to the sage-9.6 milestone Apr 11, 2022
@kliem
Copy link
Contributor Author

kliem commented Apr 11, 2022

Branch: public/33679

@kliem
Copy link
Contributor Author

kliem commented Apr 11, 2022

Commit: 5d0cbf8

@kliem
Copy link
Contributor Author

kliem commented Apr 11, 2022

New commits:

5d0cbf8use abstract_method for Polyhedra

@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 11, 2022
@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 30, 2022

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented May 22, 2022

Changed branch from public/33679 to 5d0cbf8

@vbraun vbraun closed this as completed in 88e02df May 22, 2022
@kliem kliem mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @mkoeppe @kliem