Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyhedron._test_product, _test_dilation: Skip tests if test prereqs cannot be imported #33403

Closed
mkoeppe opened this issue Feb 23, 2022 · 7 comments
Closed

Polyhedron._test_product, _test_dilation: Skip tests if test prereqs cannot be imported #33403

mkoeppe opened this issue Feb 23, 2022 · 7 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.6

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 23, 2022

CC: @kliem

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 97e6647

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/33403
@mkoeppe mkoeppe added this to the sage-9.6 milestone Feb 23, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 23, 2022

Branch: u/mkoeppe/polyhedron__test_product___test_dilation__skip_tests_if_test_prereqs_cannot_be_imported

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 23, 2022

New commits:

85bf53asrc/sage/geometry/polyhedron/base5.py (_test_dilation): Exit early if AA cannot be imported
b82b60fsrc/sage/geometry/polyhedron/base5.py (_test_product): If AA cannot be imported, skip some tests
97e6647src/sage/geometry/polyhedron/base5.py (_test_product): If polytopes.permutahedron cannot be imported, skip a test

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 23, 2022

Commit: 97e6647

@kliem
Copy link
Contributor

kliem commented Feb 23, 2022

Reviewer: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Feb 23, 2022

comment:3

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 23, 2022

comment:4

Thanks!

@vbraun
Copy link
Member

vbraun commented Mar 1, 2022

Changed branch from u/mkoeppe/polyhedron__test_product___test_dilation__skip_tests_if_test_prereqs_cannot_be_imported to 97e6647

@vbraun vbraun closed this as completed in 062a90c Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
3 participants
@vbraun @mkoeppe @kliem