Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conda: Add primecountpy #33330

Closed
tobiasdiez opened this issue Feb 13, 2022 · 9 comments
Closed

Conda: Add primecountpy #33330

tobiasdiez opened this issue Feb 13, 2022 · 9 comments
Labels
c: build p: major / 3 t: enhancement
Milestone
sage-9.6

Comments

@tobiasdiez
Copy link
Contributor

Add missing distros/conda.txt for primecountpy.

Test run: https://github.com/sagemath/sagetrac-mirror/runs/5173070066?check_suite_focus=true

CC: @isuruf @dimpase @saraedum @mkoeppe

Component: build

Author: Tobias Diez

Branch/Commit: 613198a

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/33330
@tobiasdiez tobiasdiez added this to the sage-9.6 milestone Feb 13, 2022
@tobiasdiez
Copy link
Contributor Author

Changed dependencies from 30845 to #30845

@dimpase
Copy link
Member

dimpase commented Feb 13, 2022

comment:2

looks good to me, primecount picked up from the system and tests well.

@dimpase
Copy link
Member

dimpase commented Feb 13, 2022

Reviewer: Dima Pasechnik

@tobiasdiez
Copy link
Contributor Author

comment:3

Thanks for the review!

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 14, 2022

Changed commit from e5c200a to 613198a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 14, 2022

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

613198aAdd primecountpy

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 14, 2022

comment:5

Rebased away from #30845, which is not needed as a dependency.

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 14, 2022

Changed dependencies from #30845 to none

@vbraun
Copy link
Member

vbraun commented Feb 20, 2022

Changed branch from public/build/conda-addpackages-runci to 613198a

@vbraun vbraun closed this as completed in 27c056c Feb 20, 2022
@tobiasdiez tobiasdiez mentioned this issue Jan 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
4 participants
@vbraun @dimpase @tobiasdiez @mkoeppe