-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opensuse-tumbleweed: sagelib build fails #33153
Comments
Changed upstream from Not yet reported upstream; Will do shortly. to Reported upstream. No feedback yet. |
This comment has been minimized.
This comment has been minimized.
comment:2
For our part, we already warn when the sysconfig flags contain |
comment:3
Good idea. |
comment:4
In contrast to the trouble with |
comment:5
in |
comment:6
Ok, that's a better idea, I'm trying it. |
comment:8
Need to check though if this flag works with ancient compilers that we still support New commits:
|
Commit: |
comment:9
The upstream bug is already fixed in fflas-ffpack-2.4.3. Repology says that tumbleweed is at 2.5.0. I wonder what version the reporter is using? Maybe we just bump the minimum version in |
comment:10
Replying to @orlitzky:
Nevermind. The github tag doesn't match the release tarball. |
comment:11
Anyway, I've tried to clobber my sysconfig but the build still succeeded. My system header is missing the return value. So I wonder why it worked:
|
comment:12
Perhaps a sufficiently smart compiler has optimized the issue away? |
Author: Matthias Koeppe |
comment:13
Replying to @mkoeppe:
|
comment:14
Replying to @mkoeppe:
Not this time, I used |
comment:15
I haven't figured out how to get cython to show me WTF it's actually doing yet, but watching |
comment:16
Is that using standard Sage Python packages, or using some system python packages? |
comment:17
Replying to @mkoeppe:
Unmodified rc0 with the following packages:
|
comment:18
It turns out that the python on Gentoo is already patched to avoid this very issue. Ugh. |
comment:19
Rebuilt with the python3 SPKG, and now my sysconfig changes are visible. But somehow I'm able to compile the file that was causing the OP's problem, e.g.:
|
comment:20
I would think it is sufficient to reproduce the error on the reported platform and confirm that the patch fixes it. Little point on trying to reproduce on a different platform. |
comment:22
I finally got it to fail using the fflas_ffpack SPKG. Maybe it has something to do with the autotune, who knows. Anyway, the patch works. I added some comments at the top of the file. Feel free to positive review after checking it. |
Reviewer: Michael Orlitzky |
Changed branch from u/mkoeppe/opensuse_tumbleweed__sagelib_build_fails to u/mjo/ticket/33153 |
comment:23
Thanks. |
Changed branch from u/mjo/ticket/33153 to |
comment:25
|
Changed commit from |
As reported in https://groups.google.com/g/sage-devel/c/81unMG60MyU/m/JdMKMFOSBQAJ
Workaround:
export CFLAGS="${CFLAGS} -Wno-error=return-type"
(https://groups.google.com/g/sage-devel/c/81unMG60MyU/m/TfBT8KOsBQAJ)This is caused by strict compiler flags leaking from the opensuse python3 package into user packages via sysconfig/distutils.
Same mechanism as the failures with misconfigured python3 in #31132 (homebrew), #33078 (cygwin), #32531 (pyenv)
Upstream issue:
Upstream: Reported upstream. No feedback yet.
CC: @dimpase @orlitzky
Component: build
Author: Matthias Koeppe
Branch:
fa2e672
Reviewer: Michael Orlitzky
Issue created by migration from https://trac.sagemath.org/ticket/33153
The text was updated successfully, but these errors were encountered: