Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle MAKEFLAGS in sage-spkg #33136

Open
orlitzky opened this issue Jan 9, 2022 · 0 comments
Open

Handle MAKEFLAGS in sage-spkg #33136

orlitzky opened this issue Jan 9, 2022 · 0 comments

Comments

@orlitzky
Copy link
Contributor

orlitzky commented Jan 9, 2022

In #33125 we add special MAKEFLAGS parsing to build/make/Makefile.in because the alternative would require us to modify spkg-install for all script packages. But after #29386, script packages will be handled by sage-spkg, so it makes sense to reconsider moving the MAKEFLAGS handling into sage-spkg.

This is what the documentation recommends: https://www.gnu.org/software/make/manual/html_node/POSIX-Jobserver.html

And while the end result should be the same, handling MAKEFLAGS in the script would be a bit more portable and simpler from the caller's perspective.

Depends on #29386

CC: @mkoeppe

Component: build

Issue created by migration from https://trac.sagemath.org/ticket/33136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant