Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conda-forge: Fix build of python3 spkg #33055

Closed
mkoeppe opened this issue Dec 21, 2021 · 11 comments
Closed

conda-forge: Fix build of python3 spkg #33055

mkoeppe opened this issue Dec 21, 2021 · 11 comments
Labels
c: porting p: minor / 4 t: bug
Milestone
sage-9.6

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 21, 2021

(split out from #32113)

CC: @isuruf

Component: porting

Author: Isuru Fernando

Branch/Commit: 3bcfde1

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33055
@mkoeppe mkoeppe added this to the sage-9.5 milestone Dec 21, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 21, 2021

Branch: u/mkoeppe/conda_forge__fix_build_of_python3_spkg

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 21, 2021

New commits:

7030a0fNeed rpath too when building python and override CONFIGURE_LDFLAGS only
5af7789allow building with different compilers on debian/ubuntu
e5d336fupdate compiling on debian patch

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 21, 2021

Commit: e5d336f

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 21, 2021
@slel
Copy link
Member

slel commented Jan 2, 2022

comment:3

Does this need review, or is more work needed?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 18, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a116c59Need rpath too when building python and override CONFIGURE_LDFLAGS only
db32a42allow building with different compilers on debian/ubuntu
3bcfde1update compiling on debian patch

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 18, 2022

Changed commit from e5d336f to 3bcfde1

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 18, 2022

comment:6

Rebased on current beta

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 18, 2022

comment:7

tox -e docker-conda-forge-minimal -- python3 succeeds with this

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 18, 2022

comment:8

And tox -e docker-debian-buster-minimal still works.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 18, 2022

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Mar 1, 2022

Changed branch from u/mkoeppe/conda_forge__fix_build_of_python3_spkg to 3bcfde1

@vbraun vbraun closed this as completed in 490fdfd Mar 1, 2022
@slel slel mentioned this issue Mar 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: porting p: minor / 4 t: bug
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
4 participants
@vbraun @slel @isuruf @mkoeppe