Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix E713 and E714 in schemes #32758

Closed
fchapoton opened this issue Oct 24, 2021 · 8 comments
Closed

fix E713 and E714 in schemes #32758

fchapoton opened this issue Oct 24, 2021 · 8 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.5

Comments

@fchapoton
Copy link
Contributor

about negative comparison using "is not"

CC: @tscrim @slel @kliem

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: c8499d1

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/32758
@fchapoton fchapoton added this to the sage-9.5 milestone Oct 24, 2021
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/32758

@fchapoton
Copy link
Contributor Author

New commits:

c8499d1fix E713 and E714 in schemes

@fchapoton
Copy link
Contributor Author

Commit: c8499d1

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 25, 2021

comment:2

This will create a merge conflict with #32742

@fchapoton
Copy link
Contributor Author

comment:3

bot is morally green, please review

@kliem
Copy link
Contributor

kliem commented Oct 25, 2021

comment:4

LGTM.

@kliem
Copy link
Contributor

kliem commented Oct 25, 2021

Reviewer: Jonathan Kliem

@vbraun
Copy link
Member

vbraun commented Oct 28, 2021

Changed branch from u/chapoton/32758 to c8499d1

@vbraun vbraun closed this as completed in c5a8783 Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
4 participants
@vbraun @fchapoton @mkoeppe @kliem